Bug #6142
closed
Validate and adjust apinger to dpinger parameters on upgrade
100%
Description
There are some problems reported with old apinger parameters not converting to dpinger parameters on upgrade from 2.2.* to 2.3
Review upgrade_config.inc upgrade_130_to_131() which attempts to do it, and fix as needed.
Forum: https://forum.pfsense.org/index.php?topic=109706.msg611062#msg611062
Updated by Phillip Davis over 8 years ago
Part 1 of the fix: https://github.com/pfsense/pfsense/pull/2869
That will fix the upgrade_130_to_131() step, but will only be effective for people upgrading after 2.3.1 is released.
I also have code for an upgrade_150_to_151() step that I can submit (once you are happy with part 1), which will do a validation check on existing dpinger parameters. That will be good for people upgrading from 2.3 to 2.3.1 - it can fix any remaining dodgy dpinger advanced parameter settings.
Updated by
Updated by Phillip Davis over 8 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 21300959d92cd0a2cbd8a756ee5ecf25f6193e09.
Updated by Phillip Davis over 8 years ago
Pull request https://github.com/pfsense/pfsense/pull/2872
Adds checks upgrade_150_to_151() that will double-check dpinger parameters and correct when a system currently on 2.3 with dodgy dpinger parameters is upgraded to 2.3.1
This should be the last piece of this puzzle.
Updated by Chris Buechler over 8 years ago
- Status changed from Feedback to Resolved
all works. Thanks Phil!