Project

General

Profile

Actions

Bug #6251

closed

"System Information" widget formatting breaks after on widget refresh

Added by Dmitriy K over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
-
Category:
Web Interface
Target version:
Start date:
04/25/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

See attachment.


Files

Untitled2.png (7.04 KB) Untitled2.png Dmitriy K, 04/25/2016 01:37 AM
Actions #1

Updated by Phillip Davis over 5 years ago

I was a bit surprised that decent code to do the temperature was just not there in the bootstrap-converted code, and that nobody had reported this before.
But anyway, pull request https://github.com/pfsense/pfsense/pull/2909 should fix it up.

Actions #2

Updated by Phillip Davis over 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Chris Buechler over 5 years ago

  • Status changed from Feedback to Resolved

fixed

Actions #4

Updated by Dmitriy K over 5 years ago

Fixed:
  • Temperature progress bar.
Not Fixed:
  • "MBUF Usage" value parenthesis is lost on widget refresh.
Lost Feature:
  • Temperature thresholds are not drawn (Green, Yellow, Red) as in was implemented in 2.2. My suggestion is to change progress bar color accordingly to current temp threshold or bring back colored vertical dash.
Actions #5

Updated by Phillip Davis over 5 years ago

Brackets around the MBUF usage are fixed by pull request https://github.com/pfsense/pfsense/pull/2917

Actions #6

Updated by Dmitriy K over 5 years ago

Awesome!! Thanks, Phil.

Actions #7

Updated by Phillip Davis over 5 years ago

I just looked on a 2.2.6 system. The Thermal Sensors widget shows a color scale green, yellow, red depending on the temperature.
But I don't see that on the 2.2.6 System Information Widget - it is always showing the standard red 2.2.6 "progress bar" color.

Actions #8

Updated by Steve Beaver over 5 years ago

I have to wonder why we need a temperature graph in the SI widget when we have a temperature widget to do that, and it already displays normal/warning/critical temperatures for multiple CPUs.

Do we really want to duplicate that code in the SI widget?

Actions #9

Updated by Steve Beaver over 5 years ago

This is the code the SI widget uses:

function get_temp() {
    $temp_out = get_single_sysctl("dev.cpu.0.temperature");
    if ($temp_out == "") {
        $temp_out = get_single_sysctl("hw.acpi.thermal.tz0.temperature");
    }

So it seems that for the most part we are just displaying CPU.0. When that is not available we use ACPI. I believe the thermal widget user the temperature hardware setting in system->advanced->misc

Actions #10

Updated by Dmitriy K over 5 years ago

You're right, Phillip, coloring were done in thermal sensor widget only. That's my mistake, sorry for misleading you :(

Actions

Also available in: Atom PDF