Bug #6251
closed"System Information" widget formatting breaks after on widget refresh
100%
Description
See attachment.
Files
Updated by Phillip Davis over 8 years ago
I was a bit surprised that decent code to do the temperature was just not there in the bootstrap-converted code, and that nobody had reported this before.
But anyway, pull request https://github.com/pfsense/pfsense/pull/2909 should fix it up.
Updated by Phillip Davis over 8 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset eb442fec8bd079760a53372bd9eaed7c502f2e98.
Updated by Dmitriy K over 8 years ago
- Temperature progress bar.
- "MBUF Usage" value parenthesis is lost on widget refresh.
- Temperature thresholds are not drawn (Green, Yellow, Red) as in was implemented in 2.2. My suggestion is to change progress bar color accordingly to current temp threshold or bring back colored vertical dash.
Updated by Phillip Davis over 8 years ago
Brackets around the MBUF usage are fixed by pull request https://github.com/pfsense/pfsense/pull/2917
Updated by Phillip Davis over 8 years ago
I just looked on a 2.2.6 system. The Thermal Sensors widget shows a color scale green, yellow, red depending on the temperature.
But I don't see that on the 2.2.6 System Information Widget - it is always showing the standard red 2.2.6 "progress bar" color.
Updated by Anonymous over 8 years ago
I have to wonder why we need a temperature graph in the SI widget when we have a temperature widget to do that, and it already displays normal/warning/critical temperatures for multiple CPUs.
Do we really want to duplicate that code in the SI widget?
Updated by Anonymous over 8 years ago
This is the code the SI widget uses:
function get_temp() { $temp_out = get_single_sysctl("dev.cpu.0.temperature"); if ($temp_out == "") { $temp_out = get_single_sysctl("hw.acpi.thermal.tz0.temperature"); }
So it seems that for the most part we are just displaying CPU.0. When that is not available we use ACPI. I believe the thermal widget user the temperature hardware setting in system->advanced->misc
Updated by Dmitriy K over 8 years ago
You're right, Phillip, coloring were done in thermal sensor widget only. That's my mistake, sorry for misleading you :(