Project

General

Profile

Actions

Todo #647

closed

Move CARP settings from pkg XML to a real PHP page

Added by Jim Pingle over 11 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
CARP
Target version:
Start date:
06/10/2010
Due date:
% Done:

90%

Estimated time:
Plus Target Version:
Release Notes:

Description

  • Migrate the CARP settings page from its current format as a package XML settings page to a standard PHP page
  • Migrate the carp settings out of <installedpackages>.
  • Create upgrade code to handle this transition.
Actions #1

Updated by Chris Buechler over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Darren Embry
Actions #2

Updated by Ermal Luçi over 9 years ago

This probably can wait until the new carp time comes?

Actions #3

Updated by Chris Buechler over 9 years ago

doesn't have any relation to what CARP is on the back end, just needs to be done in general.

Actions #4

Updated by Jim Pingle over 9 years ago

Might be time to promote that to its own entry under System or Firewall, "Cluster Sync" or "HA Sync" or something like that, since those settings really don't have anything to do with CARP itself, but pfsync and xmlrpc sync. Could keep the old tab and just have it link to the new location as well for now.

Personally I'm still for coming up with a catchy name for HA/clustering rather than just lumping it all under the "carp" name but I still haven't managed to come up with a new one that doesn't sound childish :-)

Actions #5

Updated by Pierre POMES over 9 years ago

And it may be nice to include some settings of "general settings" or "advanced settings":
- proxy settings
- load balancer settings
- firewall optimisation options
- max number of states
- etc..

Probably all settings could be synchronized, except the webgui SSL certificate ?

Pierre

Actions #6

Updated by Jim Pingle over 9 years ago

Pierre POMES wrote:

And it may be nice to include some settings of "general settings" or "advanced settings":
- proxy settings
- load balancer settings
- firewall optimisation options
- max number of states
- etc..

Probably all settings could be synchronized, except the webgui SSL certificate ?

That's not related to this kind of change, really. That's expanding functionality. This is just renaming/moving things around with no functional change. If you want to open a separate ticket for that we can look into it, though most of those things probably need to be kept separate. That isn't a discussion for this ticket though.

Actions #7

Updated by Chris Buechler over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee deleted (Darren Embry)

true, having it under Virtual IPs never was a sensible location, though not sure where best to put it. Need to determine where it goes and what to call it before implementing.

Actions #8

Updated by Jim Pingle over 9 years ago

Indeed, and calling it CARP Settings, IMO, contributes to the continued confusion about where the CARP heartbeats happen. At least once per week I find myself explaining to someone how the heartbeats happen on the interfaces with the VIPs, while the interfaces in the "CARP" settings are just for sync.

Some potential names:
  • HA Sync.
  • Cluster Sync.
  • Node Sync.
  • Failover Sync. (Though that may be confused with Multi-WAN or server LB)
  • Firewall Sync.
  • Router Sync.

Might need to take this to one of the mailing lists for other input/votes.

As for the location, I'd vote for the System menu. And at least for one version (maybe two) keep the old tab in that links to the new page.

Actions #9

Updated by Warren Baker over 9 years ago

My 2c, I think 'High Availability Sync' (or HA Sync) best describes the use since pfSync is a protocol which provides HA and XMLRPC is there to provide an automatic sync of the configuration on another host thus best describing the setup as HA again.
A new tab under System->Advanced for that would make sense. The 2 sections could also be split into 2 pages (under System->HA) but a page just for pfSync might just be a waste.

Actions #10

Updated by Jim Pingle over 9 years ago

Warren Baker wrote:

My 2c, I think 'High Availability Sync' (or HA Sync) best describes the use since pfSync is a protocol which provides HA and XMLRPC is there to provide an automatic sync of the configuration on another host thus best describing the setup as HA again.

Sounds good to me, or even just "Synchronization", if under System, sort of implies that as well "System > Synchronization" (though that may be too long to fit in the menu)

A new tab under System->Advanced for that would make sense. The 2 sections could also be split into 2 pages (under System->HA) but a page just for pfSync might just be a waste.

IMO think burying it on another tab would be a mistake, it's important enough to have its own menu entry, and it isn't like the System menu (or Firewall for that matter) is overflowing with options. A single page is still OK I think, given that pfsync's options are so few.

Actions #11

Updated by Warren Baker over 9 years ago

Jim P wrote:

Sounds good to me, or even just "Synchronization", if under System, sort of implies that as well "System > Synchronization" (though that may be too long to fit in the menu)

Hrmm yeah maybe even "pfSynchronization" (just to give it a pfSense feel) but probably to large for the menu. I still think High Availability best describes the section and what the options are for, Synchronization implies just syncing of configuration to an end user.
The word doesn't imply that "this is where you configure high availability for your environment".

IMO think burying it on another tab would be a mistake, it's important enough to have its own menu entry, and it isn't like the System menu (or Firewall for that matter) is overflowing with options. A single page is still OK I think, given that pfsync's options are so few.

Single page is fine, i guess if it is broken out into a single page i.e. System -> Synchronization/HA/Whatever then other tabs could be added. What these other tabs could be is another discussion.

Actions #12

Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Assigned
  • Assignee set to Darren Embry

HA Sync is the best description being clear what it's doing using sensible standard terminology, and without potentially being confusing with other functionality. I agree System menu would be the best fit, and it needs its own menu.

Actions #13

Updated by Darren Embry over 9 years ago

do we use /etc/inc/upgrade_config.inc to upgrade the config.xml side?

is there any sort of tool for converting <packagegui> files like carp_settings.xml to a full-up regular page of its own?

Actions #14

Updated by Ermal Luçi over 9 years ago

Yes for the upgrade.

For the tool it does not exist.

Actions #15

Updated by Darren Embry over 9 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 90

needs more testing than i can do but at least the convert_config() works and the settings page works: https://github.com/bsdperimeter/pfsense/commit/f97a5b0419d0350cc85b91d180238975c308ac07

Actions #16

Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Resolved

this all seems good, tested on config upgrade and starting from scratch on 2.1.

Actions

Also available in: Atom PDF