Project

General

Profile

Bug #6724

VLAN interface displayed wrong through interface assignment

Added by Clinton Cory almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Category:
-
Target version:
Start date:
08/17/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3.2
Affected Architecture:
amd64

Description

On a fresh install of 2.3.2-RELEASE (amd64-full-install), there appears to be a bug at the VLAN assignments prompt. When assigning a LAN and WAN interface, a VLAN interface will show the entire interface name (IE: igb1_vlan100) but the parent interface name is stripped once you get to the step for assigning optional interfaces. I've attached a screenshot of this.

To replicate this select Option 1 for "Assign Interfaces" through the shell
Select the option to create a VLAN when presented with the prompt "Do VLANs need to be setup first?"
Once the VLAN is created, additional prompts are presented to assign WAN, LAN, and OPT1.
The VLAN interface will display properly when assigning WAN and LAN but once you get to the OPT1 assignment the interface name is stripped.

This will be very confusing for a lot of users. You can simply input the proper interface name and it'll work.

It looks like the web menu (/etc/rc.initial) is calling a script called "/etc/rc.initial.setports" when option 1 is selected. That script references the following function:ainterfaces_ports();
This function is defined under /etc/inc/config.console.inc. I imagine the bug is located there.

Selection_001.png (98.8 KB) Selection_001.png Clinton Cory, 08/17/2016 06:02 PM

Associated revisions

Revision fd020a2d (diff)
Added by Phillip Davis almost 3 years ago

Fix #6724 VLAN interface displayed wrong

in interface assignment script dialog.

The str_replace() calls were not smart enough to just get rid of bare "igb1" when "igb1_vlan123" and such like was also in the list.

Revision f851e667 (diff)
Added by Phillip Davis over 2 years ago

Fix #6724 VLAN interface displayed wrong

in interface assignment script dialog.

The str_replace() calls were not smart enough to just get rid of bare "igb1" when "igb1_vlan123" and such like was also in the list.
(cherry picked from commit fd020a2d94077cc9c8ee6bac5b3da11e116c84a2)

Revision f2ac72d6 (diff)
Added by Phillip Davis over 2 years ago

Fix #6724 VLAN interface displayed wrong

in interface assignment script dialog.

The str_replace() calls were not smart enough to just get rid of bare "igb1" when "igb1_vlan123" and such like was also in the list.
(cherry picked from commit fd020a2d94077cc9c8ee6bac5b3da11e116c84a2)

History

#1 Updated by Phillip Davis almost 3 years ago

That's a dumb bug in the way the str_replace() calls are stripping out all the "igb1" when "igb1" gets selected for an interface.

Pull request https://github.com/pfsense/pfsense/pull/3114 should fix it.

#2 Updated by Renato Botelho over 2 years ago

  • Status changed from New to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.3.2-p1
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle over 2 years ago

  • Status changed from Feedback to Resolved

Works, following the example given it prints the interface name correctly.

Also available in: Atom PDF