Actions
Bug #7294
closedLenght of description of firewall rules
Start date:
02/22/2017
Due date:
% Done:
0%
Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All
Description
When adding or modifying a firewall rule, the description field accept more characters than are saved, so the description gets truncated.
Updated by Phillip Davis over 7 years ago
firewall_rules_edit.phpstrncpy($filterent['descr'], $_POST['descr'], 52);
I wonder why it limits that to 52?
One char per week of the year :)
I will guess that the description is later passed somewhere into the pf ruleset maybe, so it can appear somewhere in logs...?
Updated by Jim Pingle over 7 years ago
- Category set to Rules / NAT
- Target version set to 2.4.0
- Affected Version set to All
- Affected Architecture All added
- Affected Architecture deleted (
)
That's a pf limitation. We prefix user rules with "USER_RULE: " (11 chars) then the description and the total length of the description (including the prefix) has to be 63 or under. See https://github.com/pfsense/pfsense/blob/master/src/etc/inc/filter.inc#L122
63-11=52
Updated by Phillip Davis over 7 years ago
Updated by Jim Pingle over 7 years ago
- Status changed from New to Resolved
- Target version changed from 2.4.0 to 2.3.4
PR was merged and it has been working
Actions