Bug #7294: Lenght of description of firewall rules - pfSense - pfSense bugtracker

Actions

Bug #7294

closed

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Rules / NAT

Target version:

Start date:

02/22/2017

Due date:

% Done:

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

All

Affected Architecture:

All

Description

When adding or modifying a firewall rule, the description field accept more characters than are saved, so the description gets truncated.

Actions

firewall_rules_edit.php
strncpy($filterent['descr'], $_POST['descr'], 52);

I wonder why it limits that to 52?
One char per week of the year :)

I will guess that the description is later passed somewhere into the pf ruleset maybe, so it can appear somewhere in logs...?

Actions

That's a pf limitation. We prefix user rules with "USER_RULE: " (11 chars) then the description and the total length of the description (including the prefix) has to be 63 or under. See https://github.com/pfsense/pfsense/blob/master/src/etc/inc/filter.inc#L122

63-11=52

Actions