Duplicated traffic graphs
When using VLANs traffic graph shows doubled traffic for out.
Updated by Jared Dillard about 4 years ago
- Status changed from New to Confirmed
- Assignee changed from Jared Dillard to Luiz Souza
This has happened before in #3314 and was fixed in https://github.com/pfsense/pfsense-tools/commit/ad55e66a3fb817f8e54bae7bf38306039b82e3ad, then later ported in https://github.com/pfsense/FreeBSD-src/commit/939f11b196e7d22a1ce3da8533e97ff3e92510b6#diff-437f2b0c100f75faf75f7c5b60eca6a4R1156.
Then later in February 2017, the difference appears to be introduced in this commit: https://github.com/pfsense/FreeBSD-src/commit/5c1daa5ea1098b67d4c331d5e21b39178d616031
As PiBa points out on the mentioned forum thread, here is a difference in https://github.com/pfsense/FreeBSD-src/blob/RELENG_2_4/sys/net/if_vlan.c#L1132:
ifp->if_opackets++; //ifp->if_omcasts += mcast; //ifp->if_obytes += len;
if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1); if_inc_counter(ifp, IFCOUNTER_OBYTES, len); if_inc_counter(ifp, IFCOUNTER_OMCASTS, mcast);
Luiz since you made that last commit could you take a look at this? Both you and garga have made edits to the file so not sure who is best.