Project

General

Profile

Actions

Bug #8290

closed

filter.inc, make filter_expand_alias_array() return consistent results between first and second call.

Added by Pi Ba over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
Start date:
01/22/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

filter.inc, make filter_expand_alias_array() return consistent results between first and second call.

Currently the 1st php call to: filter_expand_alias_array('mixed_ip_dns_alias') does not return the fixed IP's but a second call to filter_expand_alias_array('mixed_ip_dns_alias') does.. This is at least 'unexpected'.

This is a problem for haproxy 'sourceip acl' which gets or doesnt get a list of ip's/subnets depending on how the service is started..

"Restart service" leaves the list empty.
While saving a regular configuration change the lists do get filled.
When the alias consists of both ip's/subnets and hostnames the ip's/subnets are expected to be returned with the dns items filtered out..

https://github.com/pfsense/pfsense/pull/3903

Actions #1

Updated by Pi Ba over 3 years ago

Affects: 2.4.2p1 amd64 (and probably previous versions).
Haproxy: 0.55_1 (and probably previous versions).
Progress: 100%

Actions #2

Updated by Renato Botelho over 3 years ago

  • Target version set to 2.4.3
Actions #3

Updated by Renato Botelho over 3 years ago

  • Assignee set to Renato Botelho
Actions #4

Updated by Renato Botelho over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Pi Ba over 3 years ago

Well now the haproxy usecase is broken both ways. start by 'apply config', and by 'restart service' neither fills the 'subnet list' on disk for haproxy's use.
Is there a alternative function available i could use in haproxy? Or should i implement a separate one.?

Actions #6

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved

The part of this that was broken in pfSense is OK now, but it looks like haproxy will need to implement its own function to get the results in the format it wants.

Actions

Also available in: Atom PDF