Bug #8655
closed
Radius Accounting updates are not sent in a particular situation
100%
Description
Accounting updates are not send when :
- Captiveportal auth mode is "Radius". Accounting request with updates are enabled
- no idle/hard timeout and no traffic quota are defined both by Radius server and in pfSense config
- Vouchers are not used
- "Reauthenticate users" option is not checked
This happen because of a broken if in captiveportal.inc (here : https://github.com/pfsense/pfsense/blob/master/src/etc/inc/captiveportal.inc#L766 )
/* Is there any job to do? */
if (!$timeout && !$idletimeout && !$trafficquota && !isset($cpcfg['reauthenticate']) &&
!isset($cpcfg['radiussession_timeout']) && !isset($cpcfg['radiustraffic_quota']) &&
!isset($vcpcfg['enable'])) {
return;
}
.
"&& (Accounting updates are enabled)" seems missing in the if, causing the cron job to quit without sending any radius accounting.
Updated by Renato Botelho over 5 years ago
- Status changed from New to In Progress
- Assignee set to Renato Botelho
- Target version set to 2.4.4
Updated by Renato Botelho over 5 years ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
PR merged
Updated by A FL over 5 years ago
I confirm that the fix is working. Accounting updates are now sent when using latest snapshot.
This issue can be marked as resolved.
Updated by