Project

General

Profile

Actions

Bug #8655

closed

Radius Accounting updates are not sent in a particular situation

Added by A FL over 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Category:
Captive Portal
Target version:
Start date:
07/16/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

Accounting updates are not send when :

- Captiveportal auth mode is "Radius". Accounting request with updates are enabled
- no idle/hard timeout and no traffic quota are defined both by Radius server and in pfSense config
- Vouchers are not used
- "Reauthenticate users" option is not checked

This happen because of a broken if in captiveportal.inc (here : https://github.com/pfsense/pfsense/blob/master/src/etc/inc/captiveportal.inc#L766 )

/* Is there any job to do? */
if (!$timeout && !$idletimeout && !$trafficquota && !isset($cpcfg['reauthenticate']) &&
!isset($cpcfg['radiussession_timeout']) && !isset($cpcfg['radiustraffic_quota']) &&
!isset($vcpcfg['enable'])) {
return;
}

.
"&& (Accounting updates are enabled)" seems missing in the if, causing the cron job to quit without sending any radius accounting.

Actions

Also available in: Atom PDF