Project

General

Profile

Actions

Feature #8742

closed

Remove some legacy code in auth.inc

Added by → luckman212 about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
User Manager / Privileges
Target version:
Start date:
08/03/2018
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

For completeness, I'm posting a redmine for this. Copy and pasting from PR3969:
https://github.com/pfsense/pfsense/pull/3969

There is a compat issue between PHP's $2y$ bcrypt hashes and older versions of FreeBSD, which used $2b$. However, that issue was fixed long ago in rS284483 and appeared in FreeBSD 11.0-RELEASE. This patch just removes that bit of legacy code, and another few of lines just after it "Convert ascii to unicode" that also appear completely unused. I checked for any other uses of those $astr/$ustr vars and found none. I tested this on my lab unit: Created some new user accounts, and tested login/logout/change password functions. Worked fine.

This was sparked by a recent discussion on r/PFSENSE:
https://www.reddit.com/r/PFSENSE/comments/93yezl/setting_user_passwords_in_config_xml_file/

Actions

Also available in: Atom PDF