Project

General

Profile

Actions
Copy link

Bug #9359

closed

diag_tables.php duplicate entries from webConfigurator lockout table

Added by Joshua Sign over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Web Interface
Target version:
2.4.4-p3
Start date:
02/28/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4_2
Affected Architecture:
All

Description

Entries in the webConfigurator Lockout Table are always listed, whatever the table you select.

Possible fix should be :
- add : 

unset($entries);
after line 61 in /etc/inc/auth.inc
- add : 
$entries=array();
after line 78 in /usr/local/www/diag_tables.php to avoid delete of these unwanted entries
- add : 
$entries=array();
before line 120 in /usr/local/www/diag_tables.php

Actions
Copy link
 #1

Updated by Jim Pingle over 5 years ago

  • Category set to Web Interface
  • Assignee set to Jim Pingle
  • Target version set to 2.5.0
  • Affected Architecture All added
  • Affected Architecture deleted ()

I can't reproduce this as stated, but I can see how it might happen since the variable is used without being initialized. I'm testing on PHP 7.3 which may handle that better than 7.2.

Actions
Copy link
 #2

Updated by Jim Pingle over 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Jim Pingle over 5 years ago

  • Target version changed from 2.5.0 to 2.4.4-p3
Actions
Copy link
 #4

Updated by Chris Linstruth over 5 years ago

2.4.4-p3 looks good

Tested against sshguard table since webConfiguratorlockout table has been deprecated by #9223 and replaced by sshguard.

Additions to sshguard are only shown when viewing that table, not any other tables.

Actions
Copy link
 #5

Updated by Jim Pingle over 5 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF