Project

General

Profile

Feature #9527

Add ability for LDAP extended query on groups in RFC2307 containers.

Added by Steve Powers 5 months ago. Updated 11 days ago.

Status:
Feedback
Priority:
Normal
Category:
Authentication
Target version:
Start date:
05/16/2019
Due date:
% Done:

100%

Estimated time:

Description

We have successfully deployed OpenLDAP authentication on several pfSense units, but needed to limit access to certain units based on LDAP group definitions. Support for this seems to be included for Active Directory implementations via the 'Extended Query' functionality, but when the LDAP directory uses RFC 2307 style group membership, the Extended Query does not have the ability to query the group container - I had no replies in the forum on this ability, so took at look at the PHP codebase which verified that it was not currently implemented.

I have put together a patch, that will abstract out the group container query, using the Extended Query syntax when the RFC2307 checkbox is selected. It will walk though the Authentication containers as per the original code.

I have attached the patch for comment, and to gauge interest in applying this to the main codebase.

Associated revisions

Revision 0a9163aa (diff)
Added by Steve Powers 5 months ago

Feature #9527 - LDAP extended query on groups in RFC2307 containers.

History

#1 Updated by Jim Pingle 5 months ago

  • Category set to User Manager / Privileges
  • Target version set to 2.5.0

This looks good to me at a glance, do you mind submitting this as a pull request on Github?

https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

Thanks!

#2 Updated by Steve Powers 5 months ago

I noticed there was an erroneous reference to $userdn in the last debug() function, this updated patch removes that:

#3 Updated by Steve Powers 5 months ago

Jim Pingle wrote:

This looks good to me at a glance, do you mind submitting this as a pull request on Github?

https://docs.netgate.com/pfsense/en/latest/development/submitting-a-pull-request-via-github.html

Thanks!

I have submitted a pull request. Many thanks.

https://github.com/pfsense/pfsense/pull/4067

#4 Updated by Jim Pingle 2 months ago

  • Category changed from User Manager / Privileges to Authentication

#5 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review

#6 Updated by Renato Botelho 11 days ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Also available in: Atom PDF