Project

General

Profile

Actions

Bug #9580

closed

Dynamic DNS DNSimple client errors

Added by Paul Sadauskas almost 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
Dynamic DNS
Target version:
Start date:
06/10/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4
Affected Architecture:

Description

It seems DNSimple recently updated their web server to use HTTP/2 for their API. The curl response handling code in the Dynamic DNS client uses a simple regex to look for ` 200 OK `, which no longer matches the success response from DNSimple.

DNSimple's API sends back a response like:

HTTP/2 200 \r\n
server: nginx
...

The response regex used to detect "success" for most clients in the DNSimple lib use this regex: /\s200\sOK/i

The php curl library has a function to extract the status code, it's probably safer to use that everywhere instead.

$code = curl_getinfo($ch, CURLINFO_HTTP_CODE);
if ($code == "200") {
  // ...
}

Actions #1

Updated by Jim Pingle almost 5 years ago

  • Target version set to 2.5.0
Actions #2

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Pull Request Review
Actions #3

Updated by Renato Botelho over 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #4

Updated by Jim Pingle over 4 years ago

  • Target version changed from 2.5.0 to 2.4.5
Actions #5

Updated by Jim Pingle about 4 years ago

  • Status changed from Feedback to Resolved

Not a service we can test internally, and no response from OP or other consumers of the service in question, so closing. Can revisit in a new issue if there are problems with the change.

Actions

Also available in: Atom PDF