pfSense

Move to Apache License 2.0

Review license / copyright on all files (final round)

chmod 0644 php web pages

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent. Convert page title to title case.

Cleanup

Remove closing tag followed by opening tag. Change short_open_tag to full tag and put small instructions on same line.

Status - System Logs - Move Raw Mode Row Count JQuery

Move row count JQuery to run only in raw mode.

Rename function to better represent what it really is.

Consolidate log filter code and log table header code in to common functions.

Status / System Logs - Filter Refinements

Use advanced filter in firewall dynamic view even if raw mode is set. Raw mode is not applicable to the firewall dynamic view.
Update the count in firewall dynamic view.
JQuery the actual count in raw mode instead of just displaying the max setting value....

add call 'gettext' function in the status menu files

Special Panels - Show/Hide

Add configuration option to show or hide special panels.
When a panel is hidden a button is displayed on the page title bar to toggle the panel display.

Fix status message so it displays if logging changes made.

Also print info box success.
Thanks Phil for the hint.

Rename functions per Phil suggestions.

s/miscellaneous_common_code/status_logs_common_code/
s/build_if_list/status_logs_build_if_list/

As for getGETPOSTsettingvalue I'm open to it going anywhere that makes sense. Would be nice not to need too many additional inc's to get it though. Anything in guiconfig.inc or filter_logs.inc hierarchy shouldn't require anything additional.

Status - System Logs - Consolidate - Common Functions

Factor common code section into to functions and place in include file.

getGETPOSTsettingvalue
 miscellaneous_common_code
 tab_array_logs_common

log_filter_form_system_submit
 filter_form_system

log_filter_form_firewall_submit...

Redmine #5731 Error when setting various system log settings from factory default config

Forum https://forum.pfsense.org/index.php?topic=104762.0

Merge pull request #2301 from NOYB/Staus_-_System_-_Logs_-_Write_Config_Only

Staus - System - Logs - Write Config Only

If no logging changes have been made, only write the config file.

Use Bootstraps text alignment classes

As per "http://getbootstrap.com/css/#type-alignment", use CLASS
statement instead in inline STYLE statement (much tidier)

Add max value to qty field.

Status - System Logs - Manage Log - Input Validation

Add input validation at form level in browser.
Keep PHP server side validation so as not to rely solely on the browser.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Merge pull request #2232 from NOYB/Status_-_System_Logs_-_Sort_Header

Status - System Logs - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

Code style status*

Correct <th> widths

Remove duplicate defines

Merge pull request #2209 from NOYB/Status-System_Logs-Sortable_Table

Put newest at top/bottom text with Forward/Reverse Display radio buttons for better clarity and more concise section description.

Correct tbody end tag.

Logs filename changes

Status - System Logs - Sortable Table

Rename of files to better match their position in the memory structure