pfSense

Do not generate empty tags if there is no link.

Prevent "Ignore denied clients" and "Failover Peer IP" from being combined in the DHCP server settings for IPv4. The daemon fails to start when configured in this way, it apparently only allows "allow" or "deny" in failover mode. Fixes #5898

Simplify the code with the use the newly introduced function to list CARP addresses.

Fix handling of promicuous checkbox on packet capture. Fixes #5896

Fix spacing issue with "Exclude ESP"

Merge pull request #2650 from NOYB/Firewall_/_Rules_-_Simplify_Order-Store_Loops

Merge branch 'patch-9' of https://github.com/k-paulius/pfsense

• 'patch-9' of https://github.com/k-paulius/pfsense:
  Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Restore infoblock div

Revise button icon spacing

• Converted alerts to callouts. * Split first message into paragraphs to make it more readable * Moved 2nd and 3rd messages above the applicable panels, instead of being below them; that's how it was in v2.x

Convert alert to callout

Replace alert with callout. Removed mention about greyed out icon - that is no longer applicable.

Add support for Bootstrap callouts

Headers don't need HTML entities

This commits fixes form submission on Services/UPnP redirecting to an URL with & on it.

Firewall / Rules - Simplify Order-Store Loops

Replace indexing for loops with more easily readable key/value foreach loops.
Make the order-store rules selection logic consistent with the display rules selection logic.

Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Remove Help -> Search Portal menu entry, it fixes #5894

Merge pull request #2645 from NewEraCracker/print_info_box-fix

Fix broken HTML in diag_gmirror.php

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Escape ampersands in links - part 2

Merge pull request #2641 from k-paulius/patch-7

Escape ampersands in links

For better HTML conformant with standards.

Merge pull request #2643 from NewEraCracker/html-fix

Move valign to style - part 2

Move valign to style

Make HTML conformant with standards

Escape '&' via htmlspecialchars.

Firewall / Rules - for/foreach Vars

Replace for $i var with foreach $filteri var.

Move add button outside the panel.

Only display the message if there are no entries in the table, do not display empty panel and table.

Perform HTML entity translations

Need to pass zone in the GET params so we don't get redirected to status_captiveportal.php

Rename form submit button, adjust message

Move result message to the top of the page.

Change form submit button text to 'Test'. Use alert box classes instead of text color to indicate success or failure.

Move result message to the top of the page.

Show page title because that's where page help icon is displayed.

Only display tab name in the breadcrumb if vouchers are enabled. Do not display zone name in the panel title because it is already displayed in the breadcrumb.

Fix when "No Captive Portal zones" message is displayed and do not display it inside the panel.

Code style fix.

Code style fix.

Fix DHCPv6 Server detection on DHCPv6 Relay page.

Fix DHCPv6 Relay detection on DHCPv6 Server page. It broke due to dhcrelay6 config format changes.

Merge pull request #2637 from k-paulius/patch-6

Add support for multiple span ports on bridge.

While here, fix and improve the error detection for the selected ports.

Inspired by pull request #2613 from heper/patch-1

Ticket #5871

Switch tabs places so that active tab is the first tab

Rename 'Backup/Restore' to 'Backup & Restore' so it does not clash with breadcrumb separator.

Rename NTP tab to Settings to be more user friendly.

Indicate in the breadcrumb if we are editing list item.

Rename 'DHCPv6 Server/RA' to 'DHCPv6 Server & RA' so it does not clash with breadcrumb separator.

Remove Zone: prefix before the zone name to make breadcrumb a bit shorter + it is obvious what it is

Update breadcrumb to match tab name

Show in the breadcrumb if we are modifying floating rule.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Use print_info_box() to generate alerts

Review alert wording.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

No need to state that it is a warning

Use print_info_box() to generate alerts

Use print_info_box() to generate alerts

Indicate in the breadcrumb if we are editing list item.

Perform HTML entity translation where & is used

Indicate in the breadcrumb if we are editing list item.

Merge pull request #2632 from NOYB/Interfaces_-_DHCP_Advanced_Options_Tweaks

Do not echo printf return value

Previous implementation would print both the content and return value. Changing to sprintf while retaining the short opening echo tag, echoes the content as intended and keeps code in line with the style of the project.

Interfaces - DHCP Advanced Options Checkbox Vars

Correct the Enable Checkbox Var Names

Interfaces - DHCP Advanced Options Tweaks

Lease requirements and requests typically contain large lists of options. Set the field width to use the available section space.
Apply a few tweaks for better clarity and consistency between DHCP and DHCPv6.
Include a more information link specific to each advanced panel.

Rename 'Packages' menu item to 'Package Manager' to better match with 'Cert. Manager' and 'User Manager'

Make 'Installed Packages' first tab, because it is the active tab by default.

Cert is abbreviated word so adding . to stay consistent with the usage of Avail.

Remove "headline" from the breadcrumb. It serves no real purpose, since the action that is being performed is already shown in the panel title + no other page shows action in the breadcrumb.

Add action to the breadcrumb. Rename 'Information/Tests' to 'Information & Tests' so it does not clash with breadcrumb separator.

Show package name in the breadcrumb.

Indicate in the breadcrumb if we are editing list item.

Show interface name in the breadcrumb on DHCPv6 Server page

Show interface name in the breadcrumb on DHCP Server page

Merge pull request #2630 from NOYB/Firewall_Rules_-_for/foreach

Renamed SMART to S.M.A.R.T.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent.

Use consistent webConfigurator spelling

Renamed 'Wake on LAN' to 'Wake-on-LAN'

Synchronize page titles with tab titles. Rename some titles in order to be more consistent. Convert page title to title case.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent. Convert page title to title case.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent.

Synchronize page titles with tab titles. Rename some titles in order to be more consistent. Convert page title to title case.

Show zone name in the breadcrumb of MAC, IP, hostname and voucher edit pages.

Show zone name in the breadcrumb just like it is shown on Services->Captive Portal pages.

Synchronize page titles with tab titles; Rename few titles in order to be more consistent.

Firewall Rules - for/foreach

Replace indexing for loops with more readable, and faster on arrays, key/value foreach loops.

FreeBSD doesn't yet support TFC, comment out until it does. Ticket #4688

Refine the way the DNS Forwarder and DNS Resolver are handled via XMLRPC. Fixes #5882

Background 'ipsec up' commands so they don't hang up the web GUI. Ticket #5886

Merge pull request #2623 from NOYB/Firewall_/_Rules_-_Consolidate_Move_Separators_Function

Synchronize page title with tab title. Convert page title to title case.

Add colon before zone name to make it more readable.

Synchronize page title with tab title. Renamed GRE to GREs, GIF to GIFs and LAGG to LAGGs to match VLANs, QinQs, etc.

Add missing break

Convert page title to title case

Synchronize page title with tab title