pfSense

Firewall / Aliases / Edit - Pattern

Address field is used for a wide variety of input types. Including URLs which require a much greater character set acceptance.

Allow /31 to be used for CARP IPs. Ticket #5533

Reverting change of label. It broke the display

Revise sorting to accommodate firewall logs name (logs)

Fix graph scale setting

Reverting #5771 - No longer required

Fix typo

Fixed #5771
EXCEPT that the link in the help text does not point to the correct place (yet)

Merge pull request #2448 from phil-davis/gt1

Internationalization batch 1

Display additional ooptions if value not empty

Merge pull request #2447 from phil-davis/patch-7

Merge pull request #2446 from phil-davis/patch-6

Fixed #5772

Internationalization of diag_defaults

A couple of typical fixes here:
1) Actually wrap the "Are you sure...?" question in gettext()
2) Use a single gettext() call combined with sprintf() and %s etc to construct a sentence in a single go.
3) Use %s rather than just appending a variable at the end of a sentence of text. That way there is no assumption that the variable text must go at the end in every language....

diag_confbak make a single gettext

Sentences that are constructed in pieces like this are a potential problem for translation, if the target language needs to use a different grammatical word order. e.g. in Nepali we would say datetime-dekhi datetime-samma (datetime-from datetime-to)....

Fixes some hide/show issues. An lucky bug in 2.2 was not duplicated in 2.3 so the page operated as written rather that as desired.

Merge pull request #2445 from phil-davis/patch-5

Merge pull request #2444 from phil-davis/patch-3

diag_confbak move tab_array code above diff display

At the moment the tabs "Config History" and "Backup/Restore" jump down the page below the config diff listing when a diff is displayed.
It seems better to me that the tab text stays where it is and the diff listing comes directly below it.

diag_confbak fix typo in class name

Fix product_name syntax problem in diag_backup

Notice that the old line had $g['[product_name'] - a bonus "[" - that caused the product name to not actually appear in the output.

In fixing that, I also wrapped this in sprintf() - that makes it more flexible for translation into languages where the word order of an instruction like this does not start with the verb.

Encode DHCP/DHCPv6 server additional BOOTP text options before save to XML to preserve data. It fixes #5623

Reduced header font size

Correct failure banner color

Remove unneeded var

Simplify HTML

Bootstrap style select element

Fix reboot after upgrade

HTML Compliance - VPN / IPsec / Tunnel / Edit Phase 1

End tag div seen, but there were open elements.
Unclosed element form.
<form action="vpn_ipsec_phase1.php" method="post" name="iform" id="iform">

Display correct page tabs during firmware update

Make sure $code¹ exist

Remove extra $

Should make more sense like this

Merge remote-tracking branch 'upstream/master' into strpos-fixes

Conflicts:
src/usr/local/www/pkg_mgr_install.php

Use strict comparison operators when checking strpos result

int(0) is a valid result and should not be confused with bool(false). This change will make code more future-proof. See https://secure.php.net/manual/en/function.strpos.php

Revise reboot on upgrade

Add panel heading, and make filter panel collapsible

Merge pull request #2440 from phil-davis/panel-heading

Revised reboot detection

Consistent panel-heading h2

Make all the panel-heading uses also have consistent <h2
class="panel-title"> so they all display the same size.
Forum https://forum.pfsense.org/index.php?topic=105275.0

Merge pull request #2439 from phil-davis/patch-3

Internationalize more text in diag_reboot

Internationalize more text in diag_halt

while I was looking at the panel-heading stuff, I noticed that there are whole chunks of text here that have no gettext() wrapper.

Merge pull request #2437 from NewEraCracker/php-echo-to-short

Ajax fix

Revised to handle firmware update that does not require reboot

When an error happens, $pconfig['interfaces'] is already an array

Fix space

Lowercase this opening tag

All simple php echo to short

Short version is far more used than long php echo. This brings all code to same standard where possible.

Fixed # 5770
Gave page a makeover

First part of detecting need to reboot for testing. Not yet complete

Fix status reporting (Detect rebbot required to follow)

Merge pull request #2436 from NewEraCracker/rewording

Merge pull request #2433 from NOYB/Gateways_Widget_Refactor_init-ajax

Status Logs breadcrumbs and tab array highlighting

1) When on Status Logs->VPN the VPN part of the breadcrumb list was
missing.
2) When selecting Status Logs-> System->Gateways... the underlining of
the "System" level tab went AWOL.
3) When selecting Status Logs->VPN-> PPPoE Servixce or L2TP Service the...

Maybe abbreviations could be kept to a certain acceptable minimum

Replace another abbreviation (If to Interface)

Replace another abbreviation (Int to Interface)

Replace abbreviations with complete word

Merge pull request #2434 from NewEraCracker/master

Merge pull request #2431 from phil-davis/h1

Merge pull request #2430 from phil-davis/patch-10

Merge pull request #2429 from phil-davis/patch-8

Merge pull request #2428 from phil-davis/patch-7

Merge pull request #2427 from phil-davis/patch-6

Merge pull request #2426 from phil-davis/patch-5

Merge pull request #2425 from phil-davis/patch-3

Merge pull request #2424 from phil-davis/patch-2

Merge pull request #2423 from phil-davis/headings

Change pfSense-upgrade to return time for reboot so GUI can use it

Fix misplaced parentheses

Return string and print

UI Consistency

1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g....

Use trash icon in diag states display

This had an "x" icon button. Should it be a trash icon?

Make RRD Graph VPN Users page title more friendly

Rather than ucfirst("vpnusers") becomes "Vpnusers".

LT2P Users remove random extra >

Make NAT NPt entry rows have fa edit and delete buttons

Interfaces QinQ fix closing table header tag

Fix redundant tests for reinstallpkg

Consistent use of System Update

In some places it said "System update" and in others "System Update" - be consistent.
The confirm button called it "Upgrade". Make that consistent with the existing use of the term "Update" for system updates.

Note: Packages are still said to be "upgraded" rather than "updated" - there are places where headings, confirm prompts etc will say "Upgrade package"....

Consistent headings for Dynamic DNS

Other place like "Open VPN Clients" have the "Clients" capitalized - do
it here.
Dynamic DNS has column heading "Interface" - make RFC2136 the same.
Dynamic DNS (and most other places) have a column heading "Actions" -...

More gettext~ing

Added gettext() around alert string

Fixed #5566

Don't validate 'external' when nobinat is checked

Revise tooltip

Fix no binat checkbox

Fix help

Fixed #3887

Remove duplicate "Are you sure you want to" on delete

Fix icon by including "fa" in class

Sort the Available Widgets before display
Remove unused modal

Newline is added only if both IPv4 and IPv6 addresses present

Merge pull request #2419 from NOYB/Firewall_NAT_Edit_AutoSuggest_Fix_Continued

Gateways Widget Refactor init-ajax

Move table content creation into a function so initial table load can be done normally without resize flicker.
Subsequent content updates remain via ajax.

Merge pull request #2414 from stilez/patch-18

Merge pull request #2412 from stilez/patch-16

Merge pull request #2408 from stilez/patch-12