pfSense

Fix lineup of copyright lines

and module names and other bits of formatting and typos in header
comment sections.

Welcome 2015

Balh typos

When reinstalling a package try to start it after to avoid non-expectations from people

Force pkg reinstall when asked for.

modify copyright statement to reflect reality

Tidy up "pkg_mgr_install.php" XHTML

While using the widescreen theme, when you update the firmware or add a
new package the TEXTAREAs are side-by-side which doesn't look neat.
Add BR tag between TEXTAREA

Move the fetching of a package's config file and additional files to separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing.

Remove . and / from pkg name to avoid directory traversal

Handle the reinstallall case with confirmation. Fixes #3548

Merge branch 'master-br' of https://github.com/ayvis/pfsense into ayvis-master-br

standardize URLs

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Take single and double quotes into consideration

Fixes #3460. Ask for validation when real operation will be done and ask for the operation with POST to get protection from CRSF.

Remove code that is commented

Fixes #3461. Remove any special char that can lead to shell/XSS compromises from submitted input.

Remove remaining hardcoded theme names

Tidy up "pkg_mgr_install.php" XHTML

Add start and TR tags
Tidy up the TABLE tag, move height and colspacing in to STYLE paramenter
Update TD tag with correct background syntax
Move end BODY and end HTML tags to the end of the file, this helps
reduce the error count.

Add version check to package install

Sanitize some variables
Discovered-By: Yann CAM

pkg_mgr_install - only mount rw when needed

When entering pkg_mgr_install the filesystem was being mounted rw and a backup made of the config, even if the case was "showlog" or "installedinfo". This resulted in:
a) an extra "backup" of the config being made after an install - it could be seen in Diagnostics, Backup Restore, Config History...

This is apparently breaking reinstalls. Revert "Actually make reinstallpkg remove the bionaries and really reinstall them"

This reverts commit 12b0fa564dc9b9ffe1773855e6ab528f4a5c7a5e.

Actually make reinstallpkg remove the bionaries and really reinstall them

don't show version on this page either, to match the other pages

Do not nuke /var/db/pkg now that 2.0 has better handling

Add 10 to row count on textarea

Unbreak installedinfo option

Increase textarea col size now that there is a lot more pkg install/deinstall information being output

No need to use escapeshellcmd here.

Use file_put_contents()

Redirect to the installedinfo page after package installation giving the system a chance to refresh the menus and the final installation text

Ticket #1017. Put a @ before each fwrite to silence errors. Also setup the log file in the beginning rather than on each individual function.

• Use pkg_info -E pkgname* for testing if a package is installed.
• Do not call eval if we cannot include an .inc file since that will make the whole script fail.
• Keep the log from the start to the end without overwriting. This makes debugging and problem reporting easy and explains what is done during installation....

Ticket #950. Correctly handle failures while installing packages which might leave stale information behind. Also do not try to startup services twice. Rename uninstall_package_from_name to uninstall_package because the operation on packages is only done through package names.

Ticket #873. Call write_config() before including file to avoid loosing already done modifications. While here do some code cleanup and formating to make it more readble.

Add missing )

Small gettext() fixes

Implement gettext()

Update (C) to 2010

Close before unmounting.

When removing a package delete its underlying FreeBSD pacakges.
Correct checks for avioding as much as possible errors.
Simplify logic in some cases.
Remove package include files when uninstalling packages.

NOTE: Some work is needed to have more error reporting. Espescially when failing to retrieve files or add them locally.

Increase execution time

Require filter.inc and shaper.inc

Add pfSense_BUILDER_BINARIES: and pfSense_MODULE:. Adjust Copyright to include 2009 on files that I have asserted (C) on

Since we could not use anchors now we need to reload the filter whenever we add/remove/reinstall a package.

Nuke packages for any platform

Unbreak installed information screen. After package installation the form redirects to the info page that looks identical to display the final package information and to give the menus a chance to reload with the new package options.

remove new lines

After package installation, redirect and show the installation
was OK. This has the side effect of reloading the menus so the package
can be clicked on immediately.

• Add get_after_install_info()
• Show installation instructions for package if they exist (after_install_info)

Create a backup of the configuration prior to package installation.

Correctly delete package

Correctly delete package

Whitespace and minor bug fixes for package manager pages.

Fix error: Warning: Invalid argument supplied for foreach() in /usr/local/www/pkg_mgr_install.php on line 155

Cleanup authentication code. The basic auth method, the passwd, htpasswd
and pam backing functions have been removed. The basic auth method was
legacy code and the backing functions were redundant with no added value
that I could see. A simplified replacement backing function named...

Rewrite the pfsense privilege system with the following goals in mind ...

1) Redefine page privileges to not use static urls
2) Accurate generation of privilege definitions from source
3) Merging the user and group privileges into a single set
4) Allow any privilege to be added to users or groups w/ inheritance...

Allow outputting of package log with mode=showlog&pkg=ntop for example.

Only reinstall package if it has a name.

Make scripts XSS input safe.

Pointed-out: by hoopercharles@gmail.com

Switch over to array style page titles. Obtained-from: m0n0wall

Include second argument for pkg_delete()

Ticket #1470

After package installation is completed, note that the user should configure the package and start it from the menu since this seems to be a common question/problem report.

Be kind, rewind. Restart the package after a reinstallation.

Be kind, rewind. Restart the package after a reinstallation.

Misc package changes

Submitted-by: Daniel Haischt

Remove packages with a different version tab

MFC package changes to show information better such as HEAD only packages,
etc.

Pass pkg info for reinstall pkg

Pass $pkg info

Flush output

Remove #!/usr/local/bin/php

Allow -1 return to indicated package failure. Removing exit

Move stop_service() to pkg-utils.

Stop package upon deinstall

Use sync_webgui_passwords()

Sync password database before installation.

Change name of main div to avoid conflicting

just a few modifications

updating files to use theme images
removing images from /usr/local/www
adding specific images into the correct theme directories

Sync master.passwd database before beginning package operations

Do not foreach through installedpackages['package'] if its not defined

Fix indent.

Don't fclose() the log if it doesn't exist.

Use $pgtitle

• Fix diagnostics logging tab menus
• Curve bottom of grey areas if needed
• Curve tabs
• Cleanup

Cleanup and add rounded corners.

Correct urls

Convert Packages tabs to rounded aka (display_top_tabs() calls

No need for {} surrounding a one line foreach()

make sure $todo is an array

Mount image RW before package operations

No more xmlparse_pkg.

Add "Package Installer" tab.

Update package reinstallation to use depends_on_package.

Use depends_on_package to properly remove a BSD package.

Break between progress bar and first textarea

Remove an extra newline.

Add support for XML (or package) reinstallation and package deletion.