remove more old, unused platform stuff
Fix killing of individual states for IPv6. Ticket #4906
fix whitespace
Use the appropriate source and dest IPs for all state types. Ticket #4907
Add "sockstat" output to status.php
Move cleargpt.sh and cleargmirror.sh scripts to main repo
Add 'any' option for peer ID, for mobile IPsec scenarios where you can't or don't want to check peer ID.
Remove "auto", it's just a synonym for IKEv2. Ticket #4873
include vpn.inc so IPsec CRL reload works. require_once filter.inc invpn.inc for callers there that haven't already included it.
Most of the flowtable bits were removed some time ago, take out the last of them too.
When a CRL is updated, refresh strongswan's CRLs.
Merge pull request #1775 from phil-davis/Interfaces-Widget-2-2
Add isset check for strictcrlpolicy
To be consistent with the checks in the rest of this code.
Add IPsec advanced option for strict CRL checking
fix typo
Handle IPsec Advanced Settings save before IPsec is enabled
If the Advanced Settings are saved before any other IPsec is set up then $config['ipsec'] can be just the empty string. As a result you can get:a) If you select some debug settings then those are not saved. The code to save those settings was only executed when $config['ipsec'] was already an array. Actually the code already did the necessary "if isset() then unset()" stuuf. So I just took the the "if is_array()" away from the code block....
Interfaces widget use more obscure separator RELENG_2_2
Redmine #4859 fix for RELENG_2_2
Add "netstat -ni" to status.php
Allow pre-filling (but no automatic action) of the download filename on exec.php. Setup a link to download the status output.tgz in status.php
Fix caps
Bug #4551 - consistent usage of Forwarder/Resolver across the WebGUI
Clarify that this applies to DNS Resolver as well. Update the translations template.
Clarify that this applies to DNS Resolver as well.
Merge pull request #1756 from phil-davis/traffic-graph-widget-2-2
Fix Firewall - Aliases GUI inconsistencies for URL Table type aliases
The GUI should show descriptions according to what's selected from the dropdown, but currently does not for URL Table (IPs) and URL Table (Ports) type of aliases.
This is for RELENG_2_2 branch.
Contrary to some reports this is actually usable in some cases, just notmandatory. Revert "myid_data and peerid_data fields are not relevant with asn1dn."
This reverts commit b8754cc85db7e92322f605bbb4b2f90bde90bb7f.
myid_data and peerid_data fields are not relevant with asn1dn.
Restrict serial ports glob to cua followed by alpha
Improve this a little more to match only alpha after /dev/cua (/dev/cuau for example)
Make serial ports glob cope with many more possibilities
It originally coped with things like cuau1 cuau1.1Then I made it cope with things like cuau1 cuau11 but it stopped working for cuau1.1This one copes with:cuau1cuau1.1cuau1.11cuau11cuau11.1cuau11.11...
Remove old, unused NetUtils.js
Display any advanced DHCP server settings RELENG_2_2
Cherry pick of https://github.com/pfsense/pfsense/commit/90ad3a76edae543bcc63252b14660ac4baee291e
Merge pull request #1754 from phil-davis/cr_2_2
Cancel button after input error for RELENG_2_2
Firewall Aliases Import display error message for invalid alias name
If you open firewall_aliases_import and enter just an invalid Alias Name (e.g. a$b) and press save or press save with all fields empty, then the screen redraws but the input error(s) is not displayed....
Firewall Aliases Edit ensure input_addresses array exists
If you click "+" to add an alias, then press Save without entering anything, you get:Warning: Invalid argument supplied for foreach() in /usr/local/www/firewall_aliases_edit.php on line 402as well as the various messages related to $input_errors....
Interfaces GIF Edit fix do_input_validation
Make the required fields be correct and match thier text names, which should each have their own gettext() cal so as to build a proper array at line 81. Basically it was all broken and the errors displayed when field/s were left empty were rubbish.
Interfaces GRE Edit fix required fields text
The reqdfields had only 4 entries but reqdfieldsn has 5 entries and the field names to text descriptions did not match up.Fixed it.
Interfaces PPPs edit avoid foreach() warning
If you go to Interfaces, assign, PPPs, press "+" to add an entry, then press Save without entering anything then you get a warning about the foreach() here.The is_array() check fixes it.
Fix glob for serial device names
Removing the "." that was in {,.[0-9]} allows it to match /dev/cuau10 and onward.I added lots of comments on the glob expression, because the format of the glob expression is not the same as an ordinary regex.
Fix adding of VoIP rules from traffic shaper wizard where IP/alias is notspecified.
manual merge of Phil Davis pull request, commit b45537f75b24bc323987094e459db7b2f75aa405
Fix dashboard hardware crypto display where AES-NI is enabled. Ticket
Don't check whether the QinQ interface exists when deleting. Unnecessarilymakes QinQ un-deletable where the parent interface no longer exists(removed, config restored from diff hardware, etc.).
Fix put static route destination in config change description
When enabling or disabling a route by using the enable/disable button on the Routes page, the destination network was not being put in the config change description, although the code intended it to be there....
Encode ca descr in system_camanager.php
Encode ca/cert descr in system_certmanager.php
Encode ca/cert/crl descr in system_crlmanager.php
Encode ca/cert descr in vpn_openvpn_server.php
Encode ca/cert descr in vpn_openvpn_client.php
Encode ca/cert descr in vpn_ipsec_phase1.php
Encode ca/cert descr in system_authservers.php
Encode ca/cert descr in system_usermanager.php
Encode cert/ca descr in system_advanced_admin.php
Encode cert/ca descr in services_captiveportal.php
Encode ca/cert info in openvpn_wizard.inc
Only process Traffic Graph object if it is open
Reduces useless CPU use on the pfSense box when the dashboard isdisplayed with the Traffic Graphs widget.
Add semicolon
Fix delete Java Script to match valid HTML ID
XHTML Compliance
html id's not permitted to begin with a number.html id's not permitted to contain '/'add prefix (entry_) and replace slash with hyphen.table entry id format becomes: entry_<ip address>-<cidr>replacing the format: <ip address>/<cidr>does not change the displayed format.
Move pt_BR translation from ISO to UTF-8
Move pt_BR directory, it's moving from ISO to UTF-8
Ticket #4746 Correctly set global variables to be used by hostnames cod epaths
Add a GUI field to increase the pf frag entries limit. Fixes ticket #4775
Say what is happening when reinstalling package GUI XML
At the confirmation dialog after pressing the "Reinstall XML" button, the text does not distinguish between having pressed "Reinstall the whole package" and "Reinstall the GUI/XML". It would be nice if the text of this confirmation allowed the user to be confident about which button they had just pushed, before confirming the action....
Remove load_balancer_relay_* -- They are not used, not linked, not functional, not maintained, and have potential security issues.
Why is break missing for reinstallxml
I thought that "reinstallxml" should do less than "reinstallpkg" but actually it was getting stuff here, then falling through "reinstalpkg" which did delete_package_xml and then install_pkg, which got the files a 2nd time and......
Encoding in services_unbound_advanced.php
Encoding in system_advanced_sysctl.php
Encoding in interfaces.php
Encoding in services_unbound.php
Encoding in pkg_mgr_settings.php
Encoding in system_advanced_admin.php
Encoding in interfaces_ppps_edit.php
Encoding in diag_packet_capture.php
Encoding in interfaces_qinq_edit.php
Encoding in services_dnsmasq.php
Encoding in vpn_ipsec_settings.php
More encoding
Fix some low-hanging potential security issues.
Be more careful with encoding on pages that use single quotes around HTML attributes
Additional encoding for system_advanced_misc.php
Protect single quotes as well to prevent JS injection, due to the way this page uses single quotes for attributes.
Encode parameters in system_advanced_firewall.php before displaying back to the user.
Merge manullay pull/1722
Remove the GUI for the pc-sysinstaller as well and add it to obsoletee files
Remove pc-sysinstall since it was never finished and probably will be not the choice. If needed can be resurrected. It already is in obsoleted files
status_queues missing semi-colon
This really looks like it should have a semi-colon. Somehow the PHP interpreter is not being fussy about it in this context, I guess being followed by the "endif;" keyword the interpreter guesses the previous statement must be done.
Ticket #4655 well manually merge pull/1715. Thanks: Phil
add input validation for proxy URL, port, user.
Ok another round of this which unbreaks input error validation messages
Make this right finally :). Thanks-ti: Phil-davis
Activate the redirection that for some reason got disabled
Ticket #4655 Do not behave against the logic of checkbox and description.
fix checking for overlaps of NAT destination port
Make the host uuid opt-out
Re-generate broken .mo files, it fixes #4705
Remove duplicate message
Clean up, organize, and expand the info presented by status.php. Save the output to individual text files and compress them into a .tgz for later download.
Also sanitize OpenVPN static/tls keys in status.php
Setup Wizard can result in invalid LAN DHCP pool calculation
1) consider where the LAN IP is in the subnet range and then put theDHCP pool in the biggest remaining segment, either above or below.2) Check the size of the available segment. If it is reasonably big then...
Improve setup wizard host name check
Redmine #4712It seems good enough to make the regex strings here be "reasonable". The full checks are done after pressing Next and the correct routines are called that do an exhaustive check. There seems not much point in trying to re-engineer all that here also....