pfSense

Use route_vpn_gateway for tap-type OpenVPN instances as well where specified. Remove old and wrongly copy/pasted comments while here. Ticket #5981

Check $active

Fix missing check for $active to avoid creating a route to a released lease.

Fix substr mistake

Made a silly mistake and overlooked an important difference between javascript substring() and php substr().
Tightened regex check for octal value.

Use PHP CLI explicitly to run rc.conf_mount_r(w|o) from pfSense-upgrade, it fixes #5875

Make a couple changes to PPP default gateway handling to address issues with default gateway switching. Fixes #1837
Tested with default gateway switching on and off, by rebooting, manually disconnecting the PPP link, and manually disconnecting the NIC link, worked each time, though still possible some issues remain. Feedback appreciated.

Fix #5837

Since the introduction of pkg_with_pb(), direct calls to this function
were added using the following format:

if ! pkg_with_pb ... | tee -a $logfile; then

What happened in this case is if was always getting a successfull
return code from tee call, and pkg_with_pb return was always being...

Fix #5831 using a simpler approach, just setting REPO_AUTOUPDATE=false when it's booting

Revert "Fix #5831"

This reverts commit 93a8ddf7a4c5d43cbeb623c923eb76659e6f49e0.

Save pkg call return code to use on return. The way it is now is always returning 0. It should fix #5837

Make additional packages install/delete operations to respect -n (dry-run)