pfSense

pppoe: Destroy PPPoE interface when using if_pppoe

Change interface_bring_down() to destroy pppoe interface instead of
dealing with mpd stuff if system is using if_pppoe.

(cherry picked from commit d6d167222c010516e1a7644622f5d5cc0e04c95f)

Fix rule label for default IPsec rules. Fix #16095

Move IPv4 link-locak firewall logs into a separate log preference. Implement #16092

Fix a type while here as well.

Activate snort2c log preference

Followup to b67a4eae7b9b815480789b08aa0c847f5689dede.

Move snort2c firewall logs into a separate log preference. Implement #16092

Include reason for firewall log actions. Implement #15415, Fix #16093

Show the rule for packets dropped due to IP options

When clicking the Action icon for a firewall rule log, the rule is not
shown when it's a "pass" rule that dropped the packet due to IP options.

Refactor firewall logging preferences

Move the firewall logging preferences to a single string[] variable and
make it a global. No functional changes.

Refactor filter_rules_compare()

Improve readability and avoid code duplication.

Fix typo in upgrade_238_to_239()