pfSense

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

Make fa-save the default button icon for 'Save' on all forms. Ticket #5965

Adding {} to if statement.

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext....

classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox and Chromium

Put this htmlspecialchars back, I found a better workaround for the inconsistent handling of checkboxes in packages.

Fix inconsistencies in Form_Input

renamed get_type to getType
fix capitalisation in getTagName

Don't run the checkbox label through htmlspecialchars, it breaks several packages.

Don't automatically run strings that are too long through gettext here.

Change method name to setIsRequired() to match other similar methods