Project

General

Profile

Bug #10836

TSO option does not fully toggle TSO on the interface

Added by Chris Collins 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
08/15/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.5-p1
Affected Architecture:
All

Description

I am not 100% this is a bug, it may be intended behaviour. But regardless I will attach my patch.

The VLAN_HWTSO flag is not toggled when TSO is toggled in the GUI.

Someone else posted about it on the forum here.

https://forum.netgate.com/topic/125772/vlan_hwtso

Patch attached. Tested on my local unit.

hwtsopfsense.patch (1.18 KB) hwtsopfsense.patch Chris Collins, 08/15/2020 06:15 PM

Associated revisions

Revision cd80be80 (diff)
Added by Viktor Gurov 2 months ago

Toggle VLAN_HWTSO when TSO is toggled in the GUI. Fixes #10836

History

#2 Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#3 Updated by Renato Botelho 2 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Danilo Zrenjanin about 1 month ago

  • Status changed from Feedback to Resolved

Tested on :

2.5.0-DEVELOPMENT (amd64)
built on Wed Sep 16 19:03:19 EDT 2020
FreeBSD 12.2-PRERELEASE

It works as expected.

VLAN_HWTSO flag wasn't present after I've disabled the Hardware TCP segmentation offload option.

options=6900bb<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,JUMBO_MTU,VLAN_HWCSUM,VLAN_HWFILTER,LINKSTATE,RXCSUM_IPV6,TXCSUM_IPV6>

Ticket resolved. Thank you!

Also available in: Atom PDF