Bug #10891: Captive Portal related files are not deleted after deleting CP zone in WebGUI - pfSense - pfSense bugtracker

Custom queries

2.4.5-p1 - Resolved/Closed
2.5.0 - Resolved/Closed
2.5.1 - Resolved/Closed
2.5.2 - Resolved/Closed
2.6.0 - Resolved/Closed
2.7.0 - Resolved/Closed
2.7.1 - All Open Issues
2.7.1 - Resolved/Closed
2.7.2 - Resolved/Closed
2.8.0 - All Open Bugs
2.8.0 - All Open Features
2.8.0 - All Open Issues
2.8.0 - All Open Regressions
2.8.0 - Feedback
2.8.0 - Needs Attention
2.8.0 - New/Confirmed
2.8.0 - Pull Requests
2.8.0 - Regressions affecting 2.7.0
2.8.0 - Resolved/Closed
21.02.2/2.5.1 - Resolved/Closed
21.05 Plus - All Closed Issues
21.05.1 Plus Target - All Closed Issues
21.05.1 Target - All Closed Issues
22.01 Plus - All Closed Issues
22.01 Target - All Closed Issues
22.05 Plus - All Closed Issues
22.05 Target - All Closed Issues
23.01 Plus - All Closed Issues
23.01 Target - All Closed Issues
23.05 Plus - All Closed Issues
23.05 Target - All Closed Issues
23.05.1 Plus - All Closed Issues
23.05.1 Target - All Closed Issues
23.09 Plus - All Closed Issues
23.09 Target - All Closed Issues
23.09.1 Plus - All Closed Issues
23.09.1 Target - All Closed Issues
24.03 Plus - All Closed Issues
24.03 Target - All Closed Issues
24.11 Plus - All Closed Issues
24.11 Plus - All Open Issues
24.11 Plus - Feedback Issues
24.11 Plus - Needs Attention/Work
24.11 Plus - New/Confirmed/In Progress Issues
24.11 Target - All Closed Issues
24.11 Target - All Open Issues
25.01 Plus - All Closed Issues
25.01 Plus - All Open Issues
25.01 Plus - Feedback Issues
25.01 Plus - Needs Attention/Work
25.01 Plus - New/Confirmed/In Progress Issues
25.01 Plus - Pull Request Review
25.01 Plus - Waiting on Merge
25.01 Target - All Closed Issues
25.01 Target - All Open Issues
All Open Issues assigned to Me
All Open Pull Requests
Any Target - All Open Regressions
Any Target - Feedback Issues
CE-Next - All Closed Issues (Move to specific target)
CE-Next - All Open Issues
CE-Next - Feedback (Likely needs target changed)
New Issues by Category - Future Target
New Issues by Category - No Target
New Issues by Category - No Target+Future
No Target - All Open Issues (Base Only)
No Target - New Issues (Base Only)
No Target - New Issues (Base and Packages)
Release Notes - Plus Target Version (DO NOT EDIT)
Release Notes - Target Version (DO NOT EDIT)

Actions

Copy link

Bug #10891

closed

Captive Portal related files are not deleted after deleting CP zone in WebGUI

Added by Viktor Gurov about 4 years ago. Updated about 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Viktor Gurov

Category:

Captive Portal

Target version:

2.5.0

Start date:

09/12/2020

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.4.5-p1

Affected Architecture:

Description

If you remove Captive Portal Zone on the services_captiveportal_zones.php page,
related files are still there:
/var/db/captiveportal<zone>.db
/var/db/captiveportal_usedmacs_<zone>.db
/var/db/voucher_<zone>_active_X.db
/var/db/voucher_<zone>_used_X.db

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Viktor Gurov about 4 years ago

https://github.com/pfsense/pfsense/pull/4440

Actions

Copy link

Updated by Jim Pingle about 4 years ago

Status changed from New to Pull Request Review
Target version set to 2.5.0

Actions

Copy link

Updated by Renato Botelho about 4 years ago

Status changed from Pull Request Review to Feedback
Assignee set to Renato Botelho
% Done changed from 0 to 100

PR has been merged. Thanks!

Actions

Copy link

Updated by Max Leighton about 4 years ago

Tested in:

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 04 18:53:52 EDT 2020
FreeBSD 12.2-STABLE

The captive portal related files were removed from /var/db after deleting the zone from Services>Captive Portal

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

Actions

Copy link

Updated by Anonymous about 4 years ago

Status changed from Feedback to In Progress

Actions

Copy link

Updated by Renato Botelho about 4 years ago

Assignee changed from Renato Botelho to Viktor Gurov

Viktor, can you please check this out?

Actions

Copy link

Updated by Viktor Gurov about 4 years ago

Max Leighton wrote:

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

Fix:
https://github.com/pfsense/pfsense/pull/4477

Actions

Copy link