pfSense » pfSense Packages

Selecting IPv4+IPv6 announces the route but it is counter-intuitive for someone creating an IPv4-only peer to select IPv4+IPv6, and vice-versa.

no such issue on 2.5 branch (frr 0.6.8_8),
fixed in #10789 (https://github.com/pfsense/FreeBSD-ports/pull/942):

 address-family ipv4 unicast
  neighbor 172.16.16.2 activate
  neighbor 172.16.16.2 default-originate  
  ...
 exit-address-family
 !
 address-family ipv6 unicast
  neighbor 172.16.16.2 activate
  neighbor 172.16.16.2 default-originate
  ...

see also #11039

Looks like 2.5.0 still appends a route-map to me.

 address-family ipv4 unicast
  neighbor 192.168.1.1 activate
  neighbor 192.168.1.1 default-originate  route-map ipv4  
  no neighbor 192.168.1.1 send-community
 exit-address-family

Basically, that drop-down menu should be empty unless the user defines their own route-maps. The ipv4, ipv6, and ipv4+ipv6 route maps do not exist and should not be options in the drop-down.

Yeh it's a bug, if you select IPv4+IPv6 then it'll work as expected but everything else it'll interpret at a route map.

I'll put a PR in to fix it shortly.

George Phillips wrote:

Basically, that drop-down menu should be empty unless the user defines their own route-maps. The ipv4, ipv6, and ipv4+ipv6 route maps do not exist and should not be options in the drop-down.

It's not that simple, they do need to exist for people that want to select default-originate without a route-map and possibly per address family. That's why they're there, but the selection logic isn't the best.

I suggest a checkbox to enable default-originate and a pulldown that lists the route maps for OPTIONAL inclusion.

PR: https://github.com/pfsense/FreeBSD-ports/pull/1032

Chris Linstruth wrote:

I suggest a checkbox to enable default-originate and a pulldown that lists the route maps for OPTIONAL inclusion.

I've split the route-map to a separate selection, the default-originate selection now just controls which address family it is set in.

Shouldn't there be a separate route map selection for each address family?

Chris Linstruth wrote:

Shouldn't there be a separate route map selection for each address family?

You can match both families in a single route map as long as the match statements are in separate sequences.

I know you can but why limit the configuration in such a fashion?

Checkbox for enabling default-originate IPv4 with an optional route map
Checkbox for enabling default-originate IPv6 with an optional route map

If the administrator wants them to be the same route map like it is now they can set the same route map in each family.

This works as expected for one route map spanning both families. Much better. Thank you.