Project

General

Profile

Actions
Copy link

Bug #11322

closed
JP JP

WireGuard Public Key should not be entered by the user

Bug #11322: WireGuard Public Key should not be entered by the user

Added by Jim Pingle over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
WireGuard
Target version:
2.5.0
Start date:
01/27/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.0
Affected Architecture:

Description

The WireGuard tunnel public key is derived from the private key. There isn't a compelling reason to allow the user to manually enter it separately, as it only presents an additional opportunity for error/misunderstanding.

We should make the field read only and populate it with the value derived from the private key automatically when saving.

The user will need to copy the value, however, so it must still be displayed. We could opt to not store the public key at all, but then that means we would need to run a shell command to get the public key on each page load when editing a WireGuard peer which seems undesirable.

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #1

  • Status changed from Assigned to In Progress

JP Updated by Jim Pingle over 5 years ago Actions
Copy link
 #2

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:2ccdb45478a4a7056929e455be9e0841bc8a4280.

CM Updated by Christian McDonald over 5 years ago Actions
Copy link
 #3

gitsync'ed and looking good so far

MM Updated by Marcos M over 5 years ago Actions
Copy link
 #4

Tested on Jan 29 build. Looks good.

The "Copy" link is a little odd in that it scrolls the viewport when clicking it. I don't recall other places where the functionality is used, so I'm not sure if it's any different.

RB Updated by Renato Botelho over 5 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom