Project

General

Profile

Actions
Copy link

Bug #11566

closed

Firewall Maximum Table Entries "default size" is whatever is entered

Added by Steve Y about 4 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
Marcos M
Category:
Web Interface
Target version:
2.7.2
Start date:
02/27/2021
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.09.1
Release Notes:
Default
Affected Version:
Affected Architecture:
All

Description

On at least 2.4.5 and 2.5, Firewall Maximum Table Entries has text "On this system the default size is: 2000000." Whatever number is entered in the field becomes the default. To replicate:
  1. Change 2000000 to 2000001 or any other number
  2. Click Save
  3. Note the "default" number does not change
  4. Click "Firewall & NAT" tab to reload the page
  5. Note the default is the number you entered in step 1

(tried to search for this here but couldn't find it)

Files

clipboard-202311181832-dsopt.png (11.4 KB) clipboard-202311181832-dsopt.png Jordan G, 11/19/2023 12:32 AM
Actions
Copy link
 #1

Updated by Steve Y over 1 year ago

Since it came up in forum, just noting this is still an issue on 23.05.1. (haven't updated any to 23.09 yet since it just came out)

Actions
Copy link
 #2

Updated by Marcos M over 1 year ago

The code simply reports the current value rather than keeping track of the default value (which is accurate only when no value is provided). I'm not sure it's worth the extra complexity of keeping track of the default value separately.

Actions
Copy link
 #3

Updated by Steve Y over 1 year ago

It may not be. :) And actually per https://docs.netgate.com/pfsense/en/latest/config/advanced-firewall-nat.html#firewall-maximum-table-entries the default is a fixed number of 400,000, thus not dependent "on this system" hardware at all. (unless that was trying to say, "on this pfSense version"?) Seems like options are to remove the whole sentence and let the doc page indicate the number, or change the text to list the actual default.

Actions
Copy link
 #4

Updated by Marcos M over 1 year ago

  • Status changed from New to Pull Request Review
  • Assignee set to Marcos M
  • Target version set to 2.8.0
  • Plus Target Version set to 24.03
  • Release Notes set to Default
  • Affected Architecture All added
Actions
Copy link
 #6

Updated by Marcos M over 1 year ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Jordan G over 1 year ago

applying this patch on 23.09 removes the "default" size listing below the entry field

clearing the field and saving populates it with the value from 'step 1' in op

Actions
Copy link
 #8

Updated by Steve Y over 1 year ago

A quick look at the code, I see a few of:

-['placeholder' => pfsense_default_table_entries_size()]
+['placeholder' => pfsense_current_table_entries_size()]

In lieu of rehashing the discussion of using the default, seems like the "leave this blank for the default" text should be removed, and/or not allow it to be blank?

I don't easily have a new/empty install to play with but is pfsense_current_table_entries_size() = 400000 if no value is set?

Actions
Copy link
 #9

Updated by Marcos M over 1 year ago

  • Status changed from Feedback to Resolved

We don't set a defined value by default - it's whatever the OS reports (which has its own defaults).

Actions
Copy link
 #10

Updated by Jim Pingle over 1 year ago

  • Target version changed from 2.8.0 to 2.7.2
  • Plus Target Version changed from 24.03 to 23.09.1
Actions
Copy link

Also available in: Atom PDF