Bug #11566: Firewall Maximum Table Entries "default size" is whatever is entered - pfSense - pfSense bugtracker

Custom queries

2.4.5-p1 - Resolved/Closed
2.5.0 - Resolved/Closed
2.5.1 - Resolved/Closed
2.5.2 - Resolved/Closed
2.6.0 - Resolved/Closed
2.7.0 - Resolved/Closed
2.7.1 - All Open Issues
2.7.1 - Resolved/Closed
2.7.2 - Resolved/Closed
2.8.0 - All Open Bugs
2.8.0 - All Open Features
2.8.0 - All Open Issues
2.8.0 - All Open Regressions
2.8.0 - Feedback
2.8.0 - Needs Attention
2.8.0 - New/Confirmed
2.8.0 - Pull Requests
2.8.0 - Regressions affecting 2.7.0
2.8.0 - Resolved/Closed
21.02.2/2.5.1 - Resolved/Closed
21.05 Plus - All Closed Issues
21.05.1 Plus Target - All Closed Issues
21.05.1 Target - All Closed Issues
22.01 Plus - All Closed Issues
22.01 Target - All Closed Issues
22.05 Plus - All Closed Issues
22.05 Target - All Closed Issues
23.01 Plus - All Closed Issues
23.01 Target - All Closed Issues
23.05 Plus - All Closed Issues
23.05 Target - All Closed Issues
23.05.1 Plus - All Closed Issues
23.05.1 Target - All Closed Issues
23.09 Plus - All Closed Issues
23.09 Target - All Closed Issues
23.09.1 Plus - All Closed Issues
23.09.1 Target - All Closed Issues
24.03 Plus - All Closed Issues
24.03 Target - All Closed Issues
24.07 Plus - All Closed Issues
24.07 Plus - All Open Issues
24.07 Plus - Feedback Issues
24.07 Plus - Needs Attention/Work
24.07 Plus - New/Confirmed/In Progress Issues
24.07 Plus - Pull Request Review
24.07 Plus - Waiting on Merge
24.07 Target - All Closed Issues
24.07 Target - All Open Issues
All Open Issues assigned to Me
All Open Pull Requests
Any Target - All Open Regressions
Any Target - Feedback Issues
CE-Next - All Closed Issues (Move to specific target)
CE-Next - All Open Issues
CE-Next - Feedback (Likely needs target changed)
New Issues by Category - Future Target
New Issues by Category - No Target
New Issues by Category - No Target+Future
No Target - All Open Issues (Base Only)
No Target - New Issues (Base Only)
No Target - New Issues (Base and Packages)
Release Notes - Plus Target Version (DO NOT EDIT)
Release Notes - Target Version (DO NOT EDIT)

Actions

Copy link

Bug #11566

closed

Firewall Maximum Table Entries "default size" is whatever is entered

Added by Steve Y about 3 years ago. Updated 5 months ago.

Status:

Resolved

Priority:

Low

Assignee:

Marcos M

Category:

Web Interface

Target version:

2.7.2

Start date:

02/27/2021

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

23.09.1

Release Notes:

Default

Affected Version:

Affected Architecture:

All

Description

On at least 2.4.5 and 2.5, Firewall Maximum Table Entries has text "On this system the default size is: 2000000." Whatever number is entered in the field becomes the default. To replicate:

Change 2000000 to 2000001 or any other number
Click Save
Note the "default" number does not change
Click "Firewall & NAT" tab to reload the page
Note the default is the number you entered in step 1

(tried to search for this here but couldn't find it)

Files

clipboard-202311181832-dsopt.png (11.4 KB) clipboard-202311181832-dsopt.png

Jordan G, 11/19/2023 12:32 AM

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Steve Y 6 months ago

Since it came up in forum, just noting this is still an issue on 23.05.1. (haven't updated any to 23.09 yet since it just came out)

Actions

Copy link

Updated by Marcos M 6 months ago

The code simply reports the current value rather than keeping track of the default value (which is accurate only when no value is provided). I'm not sure it's worth the extra complexity of keeping track of the default value separately.

Actions

Copy link

Updated by Steve Y 6 months ago

It may not be. :) And actually per https://docs.netgate.com/pfsense/en/latest/config/advanced-firewall-nat.html#firewall-maximum-table-entries the default is a fixed number of 400,000, thus not dependent "on this system" hardware at all. (unless that was trying to say, "on this pfSense version"?) Seems like options are to remove the whole sentence and let the doc page indicate the number, or change the text to list the actual default.

Actions

Copy link

Updated by Marcos M 6 months ago

Status changed from New to Pull Request Review
Assignee set to Marcos M
Target version set to 2.8.0
Plus Target Version set to 24.03
Release Notes set to Default
Affected Architecture All added

Actions

Copy link

Updated by Marcos M 6 months ago

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1096

Actions

Copy link

Updated by Marcos M 6 months ago

Status changed from Pull Request Review to Feedback
% Done changed from 0 to 100

Applied in changeset 50b5741beafdb34a3009b78279e203570f5e6d3f.

Actions

Copy link

Updated by Jordan G 6 months ago

File clipboard-202311181832-dsopt.png clipboard-202311181832-dsopt.png added

applying this patch on 23.09 removes the "default" size listing below the entry field

clearing the field and saving populates it with the value from 'step 1' in op

Actions

Copy link

Updated by Steve Y 6 months ago

A quick look at the code, I see a few of:

-['placeholder' => pfsense_default_table_entries_size()]
+['placeholder' => pfsense_current_table_entries_size()]

In lieu of rehashing the discussion of using the default, seems like the "leave this blank for the default" text should be removed, and/or not allow it to be blank?

I don't easily have a new/empty install to play with but is pfsense_current_table_entries_size() = 400000 if no value is set?

Actions

Copy link