Bug #11894
closedVouchers may expire too early when using RAM disks
0%
Description
We just upgraded around 10 sites from 2.4.5 to 2.5.1 and detected a strange behavior: We have created 3 voucher rolls with 2.4.5 and upgraded to 2.5.1 All of the sudden around 280 vouchers expired instantly. We deleted all voucher rolls and created (identical) new ones with 2.5.1 - and thought this solves the problem. For a few day all was fine. Today one site had a power outage and the system rebooted - and again around 280 vouchers expired. The sites without reboot are still running fine - however, the same problem occured after upgrade.
Some information about the hardware: We used APU1D4 and APU2E0 appliances.
And it is not just us having this problem, see this thread: https://forum.netgate.com/topic/162708/vouchers-getting-expired-before-remaining-time
Updated by Viktor Gurov over 3 years ago
from https://forum.netgate.com/topic/162708/vouchers-getting-expired-before-remaining-time/15:
"Voucher system working perfectly on this snapshot
2.5.0.a.20210107.2142 ( Development )
up to 2500 captive portal users renew monthly basis and there is not a single issue reported about voucher's early expiry."
but there are no special changes in captiveportal.inc/voucher.inc from that version to 2.5.1,
only #11360 and #11475
Updated by A FL over 3 years ago
The forum thread is suspecting the problem to be related to ramdisk.
If that is true, the issue could be related to
https://github.com/pfsense/pfsense/commit/896889e9fb0f1f46870a0629e81a2a7c96da5393#diff-f5eeb768632f7ec27392af0d3ad5caa1c67bb4fc56909acc85c3be2d902f820bL467 or https://github.com/pfsense/pfsense/commit/896889e9fb0f1f46870a0629e81a2a7c96da5393#diff-f5eeb768632f7ec27392af0d3ad5caa1c67bb4fc56909acc85c3be2d902f820bL643
Updated by Volker Werbus over 3 years ago
I don't think so. We are not using HA sync on the appliance.
Updated by Viktor Gurov over 3 years ago
A FL wrote:
The forum thread is suspecting the problem to be related to ramdisk.
If that is true, the issue could be related to
https://github.com/pfsense/pfsense/commit/896889e9fb0f1f46870a0629e81a2a7c96da5393#diff-f5eeb768632f7ec27392af0d3ad5caa1c67bb4fc56909acc85c3be2d902f820bL467 or https://github.com/pfsense/pfsense/commit/896889e9fb0f1f46870a0629e81a2a7c96da5393#diff-f5eeb768632f7ec27392af0d3ad5caa1c67bb4fc56909acc85c3be2d902f820bL643
Captive Portal DB/Vouchers RAM disk backup:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/246
Updated by Jim Pingle over 3 years ago
- Status changed from New to Pull Request Review
- Target version set to 2.6.0
Updated by Renato Botelho over 3 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Viktor Gurov
- Plus Target Version set to 21.09
PR has been merged. Thanks!
Updated by Jim Pingle about 3 years ago
- Subject changed from Vouchers expire too early to Vouchers may expire too early when using RAM disks
Updating subject for release notes.
Updated by Jim Pingle about 3 years ago
- Plus Target Version changed from 21.09 to 22.01