Project

General

Profile

Actions

Todo #12093

open

Make AutoConfigBackup menu entry point to the settings tab so it loads faster when there is no WAN connectivity

Added by Marcos Mendoza 7 months ago. Updated 1 day ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
Category:
Backup / Restore
Target version:
Start date:
06/29/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion

Description

When Backup Frequency is set to backup on change, changing/saving settings is delayed. This can range from only a slight but annoying delay to a longer inconvenient one resulting in a bad user experience. The backup logic should be improved with the following goals in mind:

  1. Page load times for saving changes (e.g. firewall aliases) should not be affected.
    This could be accomplished, for example, by queuing backups to a service.
  2. Navigating to Services / Auto Configuration Backup should not be affected by internet connectivity.
    Possible solution here is setting the landing page to services_acb_backup.php instead of services_acb.php.
Actions #1

Updated by Christian McDonald 7 months ago

This is something that I've actually been looking into as well over the past few days in response to work on the WireGuard package. There is certainly improvements to be made here. Going back through the acb code, I found the -NoReMoTeBaCkUp override string that can disable acb on certain calls to write_config, which I'm now using and this does help...but backup on change is still a locking process in regards to the UI. I've honestly never recommended it, and have always recommended the more conservative schedule-based approach.

In addition to a service that can handle backing up in the background, do you think it would also make sense to bust acb out of pfSense proper and rebuild it as a package? Considering the work investment in building the service you're proposing, it might also be worth it to spend a little more time to convert acb to a package, that can then be maintained and updated separately...I've obviously been thinking about packages a lot over the last 2-3 months, so I'm quite partial to this more modular paradigm.

Actions #2

Updated by Jim Pingle 7 months ago

It used to be a package, we decided to integrate it into base when it was made free to all. I don't see it moving back to a package.

Actions #3

Updated by Marcos Mendoza 2 months ago

  • Subject changed from Auto Config Backup enhancements to AutoConfigBackup enhancements
Actions #4

Updated by Viktor Gurov 2 months ago

Marcos Mendoza wrote:

  1. Navigating to Services / Auto Configuration Backup should not be affected by internet connectivity.
    Possible solution here is setting the landing page to services_acb_backup.php instead of services_acb.php.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/463

Actions #5

Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
  • Target version set to 2.6.0
  • Plus Target Version set to 22.01
Actions #6

Updated by Viktor Gurov 2 months ago

  • Status changed from Pull Request Review to Feedback

Merged

Actions #7

Updated by Max Leighton 2 months ago

Tested in

2.6.0-DEVELOPMENT (amd64)
built on Sat Nov 20 06:21:37 UTC 2021
FreeBSD 12.3-PRERELEASE

The landing page now goes to services_acb_settings.php so it loads much faster when there is no WAN connectivity

Actions #8

Updated by Jim Pingle about 2 months ago

  • Tracker changed from Feature to Todo
  • Subject changed from AutoConfigBackup enhancements to Make AutoConfigBackup menu entry point to the settings tab so it loads faster when there is no WAN connectivity

Updating subject for release notes.

Actions #9

Updated by Jim Pingle 6 days ago

  • Status changed from Feedback to Resolved

Menu entry goes to settings now as expected.

Actions #10

Updated by Marcos Mendoza 1 day ago

  • Status changed from Resolved to Pull Request Review
  • Release Notes changed from Default to Force Exclusion

From what I can tell, the changes that went in are for the DNS enhancements which #12141 is being used for. These changes do not include changing the main navigation link: https://github.com/pfsense/pfsense/blob/22f5f4d82959788bc08e96c506bebcb551e190d3/src/usr/local/www/head.inc#L321

I'm changing the redmine status for now.

Actions #11

Updated by Viktor Gurov 1 day ago

Marcos Mendoza wrote in #note-10:

From what I can tell, the changes that went in are for the DNS enhancements which #12141 is being used for. These changes do not include changing the main navigation link: https://github.com/pfsense/pfsense/blob/22f5f4d82959788bc08e96c506bebcb551e190d3/src/usr/local/www/head.inc#L321

I'm changing the redmine status for now.

main link change:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/586

Actions #12

Updated by Jim Pingle 1 day ago

  • Target version changed from 2.6.0 to 2.7.0
  • Plus Target Version changed from 22.01 to 22.05
Actions

Also available in: Atom PDF