Bug #12498
closed
Input validation error can unintentionally result in removal of PPP type interface settings
Added by Steve Wheeler almost 3 years ago.
Updated over 2 years ago.
Plus Target Version:
22.01
Affected Architecture:
All
Description
If you edit a PPPoE interface through, for example, Interfaces > WAN (interfaces.php) and change the password but do no enter matching passwords the selected physical interface is removed.
Resulting in config:
<ppp>
<ptpid>0</ptpid>
<type>pppoe</type>
<if>pppoe0</if>
<ports></ports>
<username><![CDATA[test]]></username>
<password><![CDATA[dGVzdDQ=]]></password>
<provider>testy</provider>
<bandwidth></bandwidth>
<mtu></mtu>
<mru></mru>
<mrru></mrru>
<hostuniq></hostuniq>
</ppp>
This does not happen if editing through Interfaces > Assignments > PPPs (interfaces_ppps_edit.php) where the selected interface is part of the input fields.
- Status changed from New to Pull Request Review
- Assignee set to Viktor Gurov
That looks good. Tested agaist:
2.6.0-DEVELOPMENT (amd64)
built on Tue Nov 02 05:24:11 UTC 2021
FreeBSD 12.3-PRERELEASE
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to Resolved
Tested against:
2.6.0-DEVELOPMENT (amd64)
built on Wed Nov 10 06:20:57 UTC 2021
FreeBSD 12.3-PRERELEASE
I can confirm it works as expected. Ticket resolved.
- Status changed from Resolved to New
- Status changed from New to Pull Request Review
- Status changed from Pull Request Review to Feedback
- Status changed from Feedback to Resolved
Tested in:
2.6.0-DEVELOPMENT (amd64)
built on Sat Nov 13 06:22:43 UTC 2021
FreeBSD 12.3-PRERELEASE
I can create PPPoE/L2TP/PPTP interfaces from the interfaces.php page and see the associated interfaces on interfafces_ppps.php without issues. The configs look fine. Marking the ticket resolved.
- Subject changed from Input validation can remove a PPPoE interface setting. to Input validation error can unintentionally result in removal of PPP type interface settings
Updating subject for release notes.
Also available in: Atom
PDF