Project

General

Profile

Actions
Copy link

Bug #12633

closed

Gateway monitoring should mark gateway as "offline" on PPPoE parent interface disconnect

Added by Viktor Gurov almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Gateway Monitoring
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
2.5.2
Affected Architecture:

Description

Instead of waiting for a packet loss threshold, the gateway must be marked as 'offline' on link down event

/etc/rc.linkup should be improved

Actions
Copy link
 #1

Updated by Viktor Gurov almost 3 years ago

partially implemented in https://github.com/pfsense/pfsense/commit/da836151dbd6dff0f8759ef165b24e0e173b078e,
but it does not work with PPPoE

Actions
Copy link
 #2

Updated by Viktor Gurov almost 3 years ago

  • Subject changed from Gateway monitoring should mark gateway as "offline" on interface disconnect to Gateway monitoring should mark gateway as "offline" on PPPoE parent interface disconnect
Actions
Copy link
 #4

Updated by Viktor Gurov almost 3 years ago

  • Assignee set to Viktor Gurov
Actions
Copy link
 #5

Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next
  • Plus Target Version set to 22.05
Actions
Copy link
 #6

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Jim Pingle over 2 years ago

  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #8

Updated by Alhusein Zawi over 2 years ago

GW is waiting for a packet loss threshold, it does not go to offline immediately.

tested by disabling PPPoE server.

client interface goes down (Status>Interfaces) but GW needs a few seconds to be in offline Status.

2.7.0.a.20220226.0600

Actions
Copy link
 #9

Updated by Viktor Gurov over 2 years ago

Alhusein Zawi wrote in #note-8:

GW is waiting for a packet loss threshold, it does not go to offline immediately.

tested by disabling PPPoE server.

client interface goes down (Status>Interfaces) but GW needs a few seconds to be in offline Status.

2.7.0.a.20220226.0600

To test this fix, you need to disconnect the cord from the PPPoE-enabled interface on the hardware appliance

Actions
Copy link
 #10

Updated by Danilo Zrenjanin over 2 years ago

Tested the patch:

22.05-DEVELOPMENT (arm64)
built on Tue May 10 12:33:50 UTC 2022
FreeBSD 12.3-STABLE

After removing the cable on the PPPoE (WAN) interface, it didn't mark the gateway as offline immediately. Gateway monitoring was increasing the packet loss procent.

Please check again.

Actions
Copy link
 #11

Updated by Viktor Gurov over 2 years ago

Danilo Zrenjanin wrote in #note-10:

Tested the patch:
[...]

After removing the cable on the PPPoE (WAN) interface, it didn't mark the gateway as offline immediately. Gateway monitoring was increasing the packet loss procent.

Please check again.

That's true only for switchport interfaces.
For non-switchport interfaces it works as expected.

Actions
Copy link
 #12

Updated by Danilo Zrenjanin over 2 years ago

  • Status changed from Feedback to Resolved

I retested on the SG-5100 as a PPPoE client. It works as expected. After unplugging the cable from the PPPoE parent interface, the gateway status immediately goes pending.

I am marking this ticket resolved.

Actions
Copy link

Also available in: Atom PDF