Bug #12633
closedGateway monitoring should mark gateway as "offline" on PPPoE parent interface disconnect
Added by Viktor Gurov over 4 years ago. Updated over 4 years ago.
100%
Description
Instead of waiting for a packet loss threshold, the gateway must be marked as 'offline' on link down event
/etc/rc.linkup should be improved
VG Updated by Viktor Gurov over 4 years ago Actions #1
partially implemented in https://github.com/pfsense/pfsense/commit/da836151dbd6dff0f8759ef165b24e0e173b078e,
but it does not work with PPPoE
VG Updated by Viktor Gurov over 4 years ago Actions #2
- Subject changed from Gateway monitoring should mark gateway as "offline" on interface disconnect to Gateway monitoring should mark gateway as "offline" on PPPoE parent interface disconnect
VG Updated by Viktor Gurov over 4 years ago Actions #3
VG Updated by Viktor Gurov over 4 years ago Actions #4
- Assignee set to Viktor Gurov
JP Updated by Jim Pingle over 4 years ago Actions #5
- Status changed from New to Pull Request Review
- Target version set to CE-Next
- Plus Target Version set to 22.05
VG Updated by Viktor Gurov over 4 years ago Actions #6
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset commit:13720b183efaf5697454978db93a5b4815227149.
JP Updated by Jim Pingle over 4 years ago Actions #7
- Target version changed from CE-Next to 2.7.0
AZ Updated by Alhusein Zawi over 4 years ago Actions #8
GW is waiting for a packet loss threshold, it does not go to offline immediately.
tested by disabling PPPoE server.
client interface goes down (Status>Interfaces) but GW needs a few seconds to be in offline Status.
2.7.0.a.20220226.0600
VG Updated by Viktor Gurov over 4 years ago Actions #9
Alhusein Zawi wrote in #note-8:
GW is waiting for a packet loss threshold, it does not go to offline immediately.
tested by disabling PPPoE server.
client interface goes down (Status>Interfaces) but GW needs a few seconds to be in offline Status.
2.7.0.a.20220226.0600
To test this fix, you need to disconnect the cord from the PPPoE-enabled interface on the hardware appliance
DZ Updated by Danilo Zrenjanin over 4 years ago Actions #10
Tested the patch:
22.05-DEVELOPMENT (arm64) built on Tue May 10 12:33:50 UTC 2022 FreeBSD 12.3-STABLE
After removing the cable on the PPPoE (WAN) interface, it didn't mark the gateway as offline immediately. Gateway monitoring was increasing the packet loss procent.
Please check again.
VG Updated by Viktor Gurov over 4 years ago Actions #11
Danilo Zrenjanin wrote in #note-10:
Tested the patch:
[...]After removing the cable on the PPPoE (WAN) interface, it didn't mark the gateway as offline immediately. Gateway monitoring was increasing the packet loss procent.
Please check again.
That's true only for switchport interfaces.
For non-switchport interfaces it works as expected.
DZ Updated by Danilo Zrenjanin over 4 years ago Actions #12
- Status changed from Feedback to Resolved
I retested on the SG-5100 as a PPPoE client. It works as expected. After unplugging the cable from the PPPoE parent interface, the gateway status immediately goes pending.
I am marking this ticket resolved.
Also available in: Atom