Project

General

Profile

Actions
Copy link

Bug #12710

closed

Disabling DHCP Server RRD statistics does not work

Added by John Hood almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
DHCP (IPv4)
Target version:
2.7.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
2.5.2
Affected Architecture:

Description

Seen on CE 2.5.2.

DHCP RRD stats can be enabled by a checkbox on the DHCP Services page, but disabling it on that page has no effect. Looking at /usr/local/www/services_dhcp.php I see that enable_rrd_graphing() is called when stats are enabled, but not when they are disabled. /usr/local/www/services_ntpd.php has better code for this.

Workaround-ish: Toggle RRD stats for ntpd (saving each time) after disabling RRD stats for DHCP.

Actions
Copy link
 #1

Updated by John Hood almost 3 years ago

"has no effect" means that /var/db/rrd/updaterrd.sh is not changed and DHCP RRD stats collection continues. I found this while debugging #12709.

Actions
Copy link
 #3

Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Pull Request Review
  • Assignee set to Viktor Gurov
  • Target version set to CE-Next
  • Plus Target Version set to 22.05
Actions
Copy link
 #4

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback

Merged

Actions
Copy link
 #5

Updated by Christopher Cope almost 3 years ago

  • Status changed from Feedback to Resolved

Tested and working successfully on

22.05-DEVELOPMENT (amd64)
built on Thu Feb 17 06:17:22 UTC 2022
FreeBSD 12.3-STABLE

Marking resolved.

Actions
Copy link
 #6

Updated by Jim Pingle over 2 years ago

  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #7

Updated by Jim Pingle over 2 years ago

  • Subject changed from Disabling dhcpd rrd stats doesn't work to Disabling DHCP Server RRD statistics does not work
  • Category changed from Web Interface to DHCP (IPv4)

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF