Project

General

Profile

Actions

Regression #12937

closed

Traffic Shaper wizard can produce an invalid ruleset when configured with an IPv4 upstream SIP server

Added by Danilo Zrenjanin 4 months ago. Updated 28 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Traffic Shaper Wizards
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
2.6.0
Affected Architecture:

Description

After running the traffic shaper wizard and defining an Upstream SIP server IP address under the VOIP specific settings, inappropriate floating rules will be created. Which will prevent the firewall filter from reloading.

It fails with the following log:

There were error(s) loading the rules: /tmp/rules.debug:146: rule expands to no valid combination - The line in question reads [146]: match inet6 proto udp from 192.168.33.20 to any ridentifier 1646990408 queue (qVoIP) label "USER_RULE: Connections From Upstream SIP Server" 

It looks like the Wizard defines rules using IPv4+IPv6 Address Family, which can be used only with aliases.


Related issues

Related to Feature #4769: IPv6 support in the Traffic Shaper WizardResolvedViktor Gurov06/17/2015

Actions
Actions #1

Updated by Jim Pingle 4 months ago

  • Plus Target Version changed from 21.02 to 22.05
Actions #2

Updated by Viktor Gurov 3 months ago

  • Tracker changed from Bug to Regression
  • Assignee set to Viktor Gurov
Actions #3

Updated by Viktor Gurov 3 months ago

  • Related to Feature #4769: IPv6 support in the Traffic Shaper Wizard added
Actions #4

Updated by Jim Pingle 3 months ago

  • Status changed from New to Pull Request Review
Actions #5

Updated by Viktor Gurov 3 months ago

  • Status changed from Pull Request Review to Feedback
Actions #6

Updated by Jim Pingle 3 months ago

  • Subject changed from Traffic Shaper basic Wizard rules to Traffic Shaper wizard can produce an invalid ruleset when configured with an IPv4 upstream SIP server

Updating subject for release notes.

Actions #7

Updated by Viktor Gurov 3 months ago

  • % Done changed from 0 to 100
Actions #8

Updated by Marcos Mendoza 3 months ago

Tested on 22.05.a.20220410.0600.

There are still places where it fails:

There were error(s) loading the rules: /tmp/rules.debug:230: rule expands to no valid combination - The line in question reads [230]: match inet6 proto udp from any to 10.0.5.200 ridentifier 1649625457 queue (qVoIP) label "id:1649625457" label "USER_RULE: Connections To Upstream SIP Server"

There were error(s) loading the rules: /tmp/rules.debug:227: rule expands to no valid combination - The line in question reads [227]: match on { vmx1 vmx3.521 } inet6 from 10.0.5.200 to any ridentifier 1649625679 queue (qOthersLow) label "id:1649625679" label "USER_RULE: Penalty Box"

Additionally:
  • Using the Penalty Box option results in a floating rule using the queue qOthersLow which does not exist.
  • Floating rules without a specific interface should be created with the Any interface selected instead.
Actions #9

Updated by Marcos Mendoza 3 months ago

  • Status changed from Feedback to New
Actions #10

Updated by Viktor Gurov 3 months ago

Marcos Mendoza wrote in #note-8:

Additionally:
  • Using the Penalty Box option results in a floating rule using the queue qOthersLow which does not exist.
  • Floating rules without a specific interface should be created with the Any interface selected instead.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/708

Actions #11

Updated by Jim Pingle 3 months ago

  • Status changed from New to Pull Request Review
Actions #12

Updated by Viktor Gurov 3 months ago

  • Status changed from Pull Request Review to Feedback
Actions #13

Updated by Marcos Mendoza 2 months ago

Everything works except for:

Floating rules without a specific interface should be created with the Any interface selected instead.

For reference, the option that created the empty interface list is the VOIP rules one.

Actions #14

Updated by Viktor Gurov 2 months ago

  • Status changed from Feedback to New

Marcos Mendoza wrote in #note-13:

Everything works except for:

Floating rules without a specific interface should be created with the Any interface selected instead.

For reference, the option that created the empty interface list is the VOIP rules one.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/723

Actions #15

Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review
Actions #16

Updated by Viktor Gurov 2 months ago

  • Status changed from Pull Request Review to Feedback
Actions #17

Updated by → luckman212 2 months ago

Is this at all related to https://redmine.pfsense.org/issues/13026 ? I am eager to have limiters working again on 22.05 snaps, sorry to be a PITA.

Actions #18

Updated by Marcos Mendoza 2 months ago

  • Status changed from Feedback to New

The VOIP rules were created with the Any interface. However, this error is back now:

There were error(s) loading the rules: /tmp/rules.debug:221: rule expands to no valid combination - The line in question reads [221]: match on { vmx1 vmx3.521 } inet6 from 172.19.1.10 to any ridentifier 1650416745 queue (qDefault) label "id:1650416745" label "USER_RULE: Penalty Box"

@ 2022-04-19 20:05:47

and with with "Others" option enabled:

There were error(s) loading the rules: /tmp/rules.debug:229: rule expands to no valid combination - The line in question reads [229]: match on { vmx1 vmx3.521 } inet6 from 172.19.1.10 to any ridentifier 1650417190 queue (qOthersLow) label "id:1650417190" label "USER_RULE: Penalty Box"

@ 2022-04-19 20:13:12

Actions #19

Updated by Viktor Gurov 2 months ago

Marcos Mendoza wrote in #note-18:

The VOIP rules were created with the Any interface. However, this error is back now:

There were error(s) loading the rules: /tmp/rules.debug:221: rule expands to no valid combination - The line in question reads [221]: match on { vmx1 vmx3.521 } inet6 from 172.19.1.10 to any ridentifier 1650416745 queue (qDefault) label "id:1650416745" label "USER_RULE: Penalty Box"

@ 2022-04-19 20:05:47

and with with "Others" option enabled:

There were error(s) loading the rules: /tmp/rules.debug:229: rule expands to no valid combination - The line in question reads [229]: match on { vmx1 vmx3.521 } inet6 from 172.19.1.10 to any ridentifier 1650417190 queue (qOthersLow) label "id:1650417190" label "USER_RULE: Penalty Box"

@ 2022-04-19 20:13:12

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/728

Actions #20

Updated by Jim Pingle 2 months ago

  • Status changed from New to Pull Request Review
Actions #21

Updated by Viktor Gurov 2 months ago

  • Status changed from Pull Request Review to Feedback
Actions #22

Updated by Jim Pingle 28 days ago

  • Status changed from Feedback to Resolved

Works now

Actions

Also available in: Atom PDF