Project

General

Profile

Actions

Feature #13085

closed

OpenVPN NBDD server options

Added by Phil Wardt about 2 years ago. Updated 26 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
OpenVPN
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

In first commit, I expose the NBDD servers in GUI, replace some spaces by tabs and fix the GUI bugs
Commit 1: OpenVPN: expose NBDD servers option and fix gui bugs
- add option to push NBDD servers to client in both server and specific client overrides
- in OpenVPN server, when enabling NetBios options, then WINS Servers, disabling Netbios options now properly hides WINS Servers fields
- properly do not save NetBios settings in config when NetBios option is disabled in both server and client specific overrides
- in client specific overrides: NTP and DNS options: use javascript instead of toggles class because the latter causes inverted results when repeating clicks too quickly. This also matches the code used in the server page

Optional second commit:
OpenVPN: Rename deprecated settings variables
- the netbios old settings variables are automatically converted when loading the settings file, so deprecate them in openvpn.inc

Optional last commit
Fix upstream empty() / 0 confusion
- if you set DNS/NTP servers values to 0, they will be saved in config, but on edit, the field is hidden, yet the server is properly saved as '0'.
This is because testing string 0 is false and empty() can be false for 'boolean true' and true for numeric '0'
This patch properly tests if a field has entries, text or numeric, excluding NULL, unset, empty and booleans


Files

expose_nbdd_servers-v1.0.patch (18.3 KB) expose_nbdd_servers-v1.0.patch Phil Wardt, 04/22/2022 03:50 AM
openvpn_nbdd.patch (6.35 KB) openvpn_nbdd.patch Phil Wardt, 11/06/2023 06:39 PM
Actions

Also available in: Atom PDF