pfSense

I can't think of any benefit from fixing it; better to remove it.

PR: https://github.com/pfsense/pfsense/pull/4596

I haven't used links against in the GUI in quite some time so I'm not sure if it still works. If it does we may as well fix the code there. If not we can remove it.

The code can be changed to read the specific tag from the config rather than using grep, the grep method is quite outdated.

    protocol=`/usr/local/sbin/read_xml_tag.sh string system/webgui/protocol`
    if [ "${protocol}" = "https" ]; then
        links "https://localhost" 
    else
        links "http://localhost" 
    fi

Can't use the value of protocol directly as it may not be present in the configuration.

Ok I updated the PR to bring back the hidden option 100 / links browser. I think this is good. Unfortunately when I tested it, I was able to get to a login page, and successfully authenticated (saw that message on the console) but the dashboard never loaded. Regardless, that's for another issue -- hopefully this is good for now.

    protocol=$(/usr/local/sbin/read_xml_tag.sh string system/webgui/protocol)
    port=$(/usr/local/sbin/read_xml_tag.sh string system/webgui/port)
    if [ -z "$port" ]; then
        case $protocol in
            https) port=443;;
            *)     port=80;;
        esac
    fi
    links "${protocol}://localhost:${port}" 

• removed case 111)
• consistency of single/double quotes
• removed a couple of stray ; s