Project

General

Profile

Actions

Bug #13258

closed

Hidden menu option ``100`` incorrectly handles HTTPS detection

Added by → luckman212 almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Console Menu
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

I was poking around in /etc/rc.initial to try to fix something else and I noticed a hidden menu item 100

This opens the text-based links browser. Neat.

I guess that could be useful, but the code below looks a little silly and is incorrect. It just greps config.xml and if the string https is anywhere in there (which it's likely to be) then the browser tries to open https://localhost which is also very likely to be incorrect (maybe we're running on port 4443?).


65   CONFIG="/cf/conf/config.xml" 
66   WORD="https" 
...
257  100)
258      if grep "$WORD" "$CONFIG"; then
259          links "https://localhost" 
260      else
261          links "http://localhost" 
262      fi
263      ;;

I think this should either be removed or changed to open e.g. https://google.com or https://netgate.com


Files

clipboard-202212031938-mrhwj.png (29.4 KB) clipboard-202212031938-mrhwj.png console_option100 Jordan G, 12/03/2022 07:38 PM
Actions

Also available in: Atom PDF