Project

General

Profile

Actions

Bug #13436

closed

Input validation on ``system_advanced_firewall.inc`` uses incorrect variable references for some fields

Added by Jared Hendrickson over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

A few fields in /usr/local/pfSense/include/www/system_advanced_firewall.inc are being incorrectly validated.

- `adaptiveend` is incorrectly being referred to as `adaptive-end` during validation.
- `maximumstates` is incorrectly being referred to as `firewall-maximum-states` during validation.
- `aliasesresolveinterval` is incorrectly being referred to as `aliases-hostnames-resolve-interval` during validation. (On the frontend, this field also has its input type `type=text` so any arbitrary value could be entered and accepted here.)
- `maximumtableentries` is incorrectly being referred to as `firewall-maximum-table-entries` during validation, but is validated correctly further down in the file.

I searched for references to the incorrect names and only see them in this file so I'm assuming they were just leftover from a refactor at some point.

Actions

Also available in: Atom PDF