Project

General

Profile

Actions

Todo #13524

closed
MM MM

Update reserved alias names

Todo #13524: Update reserved alias names

Added by Marcos M almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Aliases / Tables
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion

Description

From /sbin/pfctl/parse.y

MM Updated by Marcos M almost 4 years ago Actions #1

Original (from parse.y):

    'all', 'allow-opts', 'altq', 'anchor', 'antispoof', 'any', 'bandwidth', 'binat', 'binat-anchor', 'bitmask',
    'block', 'block-policy', 'buckets', 'cbq', 'code', 'codelq', 'crop', 'debug', 'divert-reply', 'divert-to',
    'dnpipe', 'dnqueue', 'drop', 'drop-ovl', 'dup-to', 'ether', 'fail-policy', 'fairq', 'fastroute', 'file',
    'fingerprints', 'flags', 'floating', 'flush', 'for', 'fragment', 'from', 'global', 'group', 'hfsc', 'hogs',
    'hostid', 'icmp-type', 'icmp6-type', 'if-bound', 'in', 'include', 'inet', 'inet6', 'interval', 'keep',
    'keepcounters', 'l3', 'label', 'limit', 'linkshare', 'load', 'log', 'loginterface', 'map-e-portset', 'match',
    'max', 'max-mss', 'max-src-conn', 'max-src-conn-rate', 'max-src-nodes', 'max-src-states', 'min-ttl', 'modulate',
    'nat', 'nat-anchor', 'no', 'no-df', 'no-route', 'no-sync', 'on', 'optimization', 'os', 'out', 'overload',
    'pass', 'port', 'prio', 'priority', 'priq', 'probability', 'proto', 'qlimit', 'queue', 'quick', 'random',
    'random-id', 'rdr', 'rdr-anchor', 'realtime', 'reassemble', 'reply-to', 'require-order', 'return', 'return-icmp',
    'return-icmp6', 'return-rst', 'ridentifier', 'round-robin', 'route', 'route-to', 'rtable', 'rule',
    'ruleset-optimization', 'scrub', 'set', 'set-tos', 'skip', 'sloppy', 'source-hash', 'source-track', 'state',
    'state-defaults', 'state-policy', 'static-port', 'sticky-address', 'syncookies', 'synproxy', 'table', 'tag',
    'tagged', 'target', 'tbrsize', 'timeout', 'to', 'tos', 'ttl', 'upperlimit', 'urpf-failed', 'user'

Original fuzzy:

    'allowopts', 'binatanchor', 'blockpolicy', 'divertreply', 'divertto', 'duptoicmptype', 'icmp6type',
    'ifboundmaxmss', 'maxsrcconn', 'maxsrcconnrate', 'maxsrcnodes', 'maxsrcstates', 'minttl', 'natanchornodf',
    'noroute', 'nosync', 'randomidrdranchor', 'replyto', 'requireorderreturnicmp', 'returnicmp6',
    'returnrstroundrobinrouteto', 'ruleset_optimization', 'settos', 'sourcehash', 'sourcetrackstatedefaults',
    'statepolicy', 'staticport', 'stickyaddress', 'urpffailed'

New (to be included from original):

    'crop', 'dnpipe', 'dnqueue', 'drop-ovl', 'ether', 'fail-policy', 'file', 'keepcounters', 'l3', 'map-e-portset',
    'match', 'ridentifier', 'syncookies'

Custom (pfSense specific):

    'arrow', 'codel', 'error', 'filename', 'fragcrop', 'fragdrop', 'IPsec', 'L2TP', 'maximummin', 'OpenVPN', 'pppoe', 'pptp'

MM Updated by Marcos M almost 4 years ago Actions #2

  • Subject changed from Update reserved alias names table to Update reserved alias names

MM Updated by Marcos M almost 4 years ago Actions #3

  • Tracker changed from Bug to Todo
  • Status changed from New to Pull Request Review

CM Updated by Christian McDonald almost 4 years ago Actions #4

  • Status changed from Pull Request Review to Feedback
  • Release Notes changed from Default to Force Exclusion

MM Updated by Marcos M almost 4 years ago Actions #5

  • % Done changed from 0 to 100

Applied in changeset commit:286e685d14b8148182a5c9f28d3eeddd215a9a08.

JP Updated by Jim Pingle almost 4 years ago Actions #6

  • Plus Target Version changed from 22.11 to 23.01

CL Updated by Chris Linstruth almost 4 years ago Actions #7

Minor nit but it looks like if the keyword is included in two different sections (Like Original and New) the error message is sent twice.

The following input errors were detected:
    Cannot use a reserved keyword as an alias name: file
    Cannot use a reserved keyword as an alias name: file
    There may be additional errors. Fix the noted problems and try again.

Seems to prevent the aliases from being created just fine.

MM Updated by Marcos M almost 4 years ago Actions #8

  • Status changed from Feedback to Pull Request Review

MM Updated by Marcos M almost 4 years ago Actions #9

  • Status changed from Pull Request Review to Feedback

Applied in changeset commit:a637e8eccca0955a2ca8d97f18d94f7fca8c8bc2.

MM Updated by Marcos M almost 4 years ago Actions #10

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom