Bug #13531
closed
pfSense - Feature #13446: Upgrade PHP from 7.4 to 8.1
Suricata GUI broken with PHP 8.1
100%
Description
Opening this ticket as a generic placeholder for documenting PHP 8.1 issues in the Suricata GUI package.
Installation of the package will not complete the final step of adding a menu entry, and while the source code files successfully install, when you attempt to launch the package start page it throws a PHP 8.1 error. There are also other PHP 8.1 related issues within the package code.
I am working on these issues and tracking them in my private TODO list. Will update this ticket when the fixes are posted.
Updated by Bill Meeks over 1 year ago
The PHP8 errors have been fixed in Pull Request 1192 posted to the pfSense Package DEVEL branch on GitHub here: [https://github.com/pfsense/FreeBSD-ports/pull/1192].
After review and merging by the Netgate development team, this issue can be marked RESOLVED.
Updated by Kris Phillips over 1 year ago
- Status changed from New to Confirmed
Installation of Suricata is fixed in September 30th builds and all main menu items are loading now.
However, attempting to add an interface for Suricata produces the following error:
Fatal error: Unparenthesized `a ? b : c ? d : e` is not supported. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` in /usr/local/pkg/suricata/suricata_generate_yaml.php on line 396 PHP ERROR: Type: 64, File: /usr/local/pkg/suricata/suricata_generate_yaml.php, Line: 396, Message: Unparenthesized `a ? b : c ? d : e` is not supported. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`
I'm reviewing other sub-menus to verify there are no others like this.
Updated by Kris Phillips over 1 year ago
Testing all other menus and buttons seems to produce no errors. However, there are some menus that cannot be accessed or tested without a valid interface, which I cannot add due to the above issue.
Updated by Danilo Zrenjanin over 1 year ago
I am getting the same error as Kris. But it seems that PHP8 compatibility issues fixes are included in the 6.0.6_1, which is not offered in Sep 30 release.
Updated by Bill Meeks over 1 year ago
I believe all of the PHP8 issues are fixed in the pull request I offered, but it has not been merged pending review by Netgate.
Once it is merged I think Suricata will be functional.
The error experienced by Kris is definitely fixed in the pending pull request.
Updated by Bill Meeks over 1 year ago
And one further note -- I am the volunteer package maintainer for Suricata and Snort in case any of the newer Netgate team folks are unaware. I believe all the issues identified are corrected in the posted pull requests for both Suricata and Snort.
Updated by Jim Pingle over 1 year ago
- Affected Plus Version changed from 22.11 to 23.01
Updated by Bill Meeks over 1 year ago
This issue and several other PHP 8.1 related issues in the Suricata package have been resolved by the merging of Pull Request 1192 detailed here: https://github.com/pfsense/FreeBSD-ports/pull/1192.