Project

General

Profile

Actions
Copy link

Bug #13539

closed

Missing descriptions for referrers to firewall aliases cause empty strings for references to be returned when deleting an in-use alias

Added by Reid Linnemann over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Reid Linnemann
Category:
Aliases / Tables
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

If an alias is in use by another alias, filter rule, nat rule, route, or OVPN configuration, attempting to delete it results in an error indicating that the alias is still in use. The code attempts to build a list of all of the referrers, but only does so by collecting 'descr' or 'description' attributes of them, which is not guaranteed to be populated resulting in no identifier for the referer being displayed.

Actions
Copy link
 #1

Updated by Jim Pingle over 1 year ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #2

Updated by Reid Linnemann over 1 year ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Alhusein Zawi over 1 year ago

the error when deleting used alias "Cannot delete alias. Currently in use by filter rule id 3. " in built of Fri Oct 21 06:05:28 UTC 2022

while it was "Cannot delete alias. Currently in use by ." in built of Fri Sep 30 20:10:57 UTC 2022

both were without Description

Actions
Copy link
 #4

Updated by Reid Linnemann over 1 year ago

Alhusein Zawi wrote in #note-3:

the error when deleting used alias "Cannot delete alias. Currently in use by filter rule id 3. " in built of Fri Oct 21 06:05:28 UTC 2022

while it was "Cannot delete alias. Currently in use by ." in built of Fri Sep 30 20:10:57 UTC 2022

both were without Description

This appears to be verification that the changes are producing acceptable and expected output for your case, can you confirm?

Actions
Copy link
 #5

Updated by Danilo Zrenjanin over 1 year ago

  • Status changed from Feedback to Resolved

Tested against:

23.01-DEVELOPMENT (amd64)
built on Fri Dec 02 06:04:48 UTC 2022
FreeBSD 14.0-CURRENT

When I tried to delete the alias used in a rule and route, I got:

Cannot delete alias. Currently in use by filter rule id 0, route id 0.

I deleted the rule with the alias and when tried to delete it I got:

Cannot delete alias. Currently in use by route id 0.

It works as expected. I am marking this ticket resolved.

Actions
Copy link

Also available in: Atom PDF