Project

General

Profile

Actions

Feature #13575

closed

Update to frr 9.0.1

Added by Marcos M over 1 year ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
FRR
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
23.09

Description

The current frr package version is 7.5.1_3 - frr 7.5.1 was released on 2021-03-07 https://github.com/FRRouting/frr/releases/tag/frr-7.5.1

The ports tree now includes frr8 with many fixes and enhancements. Upgrading likely requires updates to the pfSense GUI as well. Alternatively, packages for both frr7 and frr8 could be made available.


Related issues

Related to Bug #14808: Configuring RPKI may break BGPClosed

Actions
Has duplicate Feature #13931: Upgrade FRR from 7.x to 8.xDuplicateChristian McDonald

Actions
Actions #1

Updated by Marcos M over 1 year ago

  • Subject changed from Ugrade to frr8 to Upgrade frr package to frr8
Actions #2

Updated by Carlos Daniel Silva about 1 year ago

Marcos M wrote:

The current frr package version is 7.5.1_3 - frr 7.5.1 was released on 2021-03-07 https://github.com/FRRouting/frr/releases/tag/frr-7.5.1

The ports tree now includes frr8 with many fixes and enhancements. Upgrading likely requires updates to the pfSense GUI as well. Alternatively, packages for both frr7 and frr8 could be made available.

This version of FRR is very obsolete because it does not have the option to redistribute the default route to ipv6

Actions #3

Updated by Jim Pingle about 1 year ago

  • Tracker changed from Todo to Feature
  • Subject changed from Upgrade frr package to frr8 to Upgrade FRR from 7.x to 8.x
  • Assignee set to Christian McDonald

When this happens it's best to just move to 8.x and not keep two versions around.

Actions #4

Updated by Jim Pingle about 1 year ago

Actions #5

Updated by Marcos M 7 months ago

Tested in 23.09 by running:

pkg delete -f frr7 frr7-pythontools
pkg install -f frr8 frr8-pythontools

The config tested OSPF, BGP peers with multiple neighbors, AS Paths, Access Lists, Prefix Lists, Route Maps, and BFD. After re-saving all GUI pages, the generated raw config was the same. I looked over the release notes since FRR 7.5.1 to 8.5.2 and didn't notice anything that would prevent an in-place upgrade from working as-is. One thing did stand out:

Ignore end when parsing frr.conf. If frr.conf has end inside the config, BGP peering starts only after 10 minutes. This is because parsing the end keyword stopped hooks from reaching the end of the configuration and BGP thoughts the configuration is not ready.

I tested again after applying the following patch to remove end from the config file, and did not find any issues:

diff --git a/net/pfSense-pkg-frr/files/usr/local/pkg/frr.inc b/net/pfSense-pkg-frr/files/usr/local/pkg/frr.inc
index e802a02a75b5..f8c7cd6cb2a5 100644
--- a/net/pfSense-pkg-frr/files/usr/local/pkg/frr.inc
+++ b/net/pfSense-pkg-frr/files/usr/local/pkg/frr.inc
@@ -830,7 +830,6 @@ function frr_generate_config_integrated() {

         $integratedconffile .= "line vty\n";
         $integratedconffile .= "!\n";
-        $integratedconffile .= "end\n";

         /* Remove sample configuration files */
         array_map('unlink', glob("{$frr_config_base}/*.sample*"));

Actions #6

Updated by Marcos M 7 months ago

  • Status changed from New to Feedback
  • Assignee changed from Christian McDonald to Marcos M
  • Target version set to 2.8.0
  • Plus Target Version set to 23.09
Actions #7

Updated by Jim Pingle 7 months ago

  • Status changed from Feedback to In Progress

This appears to be functioning OK for the most part but it isn't building with the SNMP option enabled yet. There is a fix we're waiting on there still:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272757

Will need to wait for that and test further.

Actions #8

Updated by Marcos M 6 months ago

  • Subject changed from Upgrade FRR from 7.x to 8.x to Upgrade frr
  • Status changed from In Progress to Waiting on Merge

Since frr9 has been released, we can upgrade to that instead. Ideally, it will be merged upstream first:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273790

An MR is available for the pfSense package, currently pending the port update:
https://gitlab.netgate.com/pfSense/FreeBSD-ports/-/merge_requests/364

Actions #9

Updated by Jim Pingle 5 months ago

  • Related to Bug #14808: Configuring RPKI may break BGP added
Actions #10

Updated by Marcos M 5 months ago

  • Subject changed from Upgrade frr to Update to frr 9.0.1
  • Status changed from Waiting on Merge to Feedback

Updated to frr 9.0.1 in 23.09 dev branch.

Actions #11

Updated by Alhusein Zawi 5 months ago

FRR 9.0.1 is added and working

23.09-BETA (amd64)
built on Thu Oct 12 23:00:00 PDT 2023
FreeBSD 14.0-CURRENT

Actions #12

Updated by Marcos M 5 months ago

  • Status changed from Feedback to Resolved
Actions #13

Updated by Jim Pingle 4 months ago

  • Target version changed from 2.8.0 to 2.7.1
Actions

Also available in: Atom PDF