Project

General

Profile

Actions

Regression #13599

closed
BD CM

Feature #13446: Upgrade PHP from 7.4 to 8.1

Error when disabling sshd

Regression #13599: Error when disabling sshd

Added by Brad Davis almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
PHP Interpreter
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
23.01
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

On system_advanced_admin.php when unchecking the 'Enable Secure Shell' and saving the page give this error:

```
Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pfSense/include/www/system_advanced_admin.inc:420 Stack trace: #0 /usr/local/www/system_advanced_admin.php(434): restart_SSHD() #1 {main} thrown in /usr/local/pfSense/include/www/system_advanced_admin.inc on line 420 PHP ERROR: Type: 1, File: /usr/local/pfSense/include/www/system_advanced_admin.inc, Line: 420, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pfSense/include/www/system_advanced_admin.inc:420 Stack trace: #0 /usr/local/www/system_advanced_admin.php(434): restart_SSHD() #1 {main} thrown
```

MM Updated by Marcos M almost 4 years ago Actions #1

Could not replicate on pfSense-23.01.a.20221026.0600.

CM Updated by Christian McDonald almost 4 years ago Actions #2

  • Status changed from New to Feedback
  • Assignee changed from Reid Linnemann to Christian McDonald

Could be a problem. I went ahead and updated the config access to the new API.

https://gitlab.netgate.com/pfSense/pfSense/-/commit/042d75c8efab83bbc7978e58d50c45d43a3a4e0c

CM Updated by Christian McDonald almost 4 years ago Actions #3

  • % Done changed from 0 to 100

Applied in changeset commit:042d75c8efab83bbc7978e58d50c45d43a3a4e0c.

CC Updated by Christopher Cope almost 4 years ago Actions #4

  • Status changed from Feedback to Resolved

I was able to reproduce it on

23.01-DEVELOPMENT (amd64)
built on Wed Oct 26 09:24:05 CEST 2022
FreeBSD 14.0-CURRENT

tested on
23.01-DEVELOPMENT (amd64)
built on Fri Oct 28 06:06:21 UTC 2022
FreeBSD 14.0-CURRENT

and it's working as expected. Marking resolved.

JP Updated by Jim Pingle almost 4 years ago Actions #5

  • Parent task set to #13446
  • Release Notes changed from Default to Force Exclusion

JP Updated by Jim Pingle almost 4 years ago Actions #6

  • Tracker changed from Bug to Regression
Actions

Also available in: Atom