pfSense » pfSense Packages

I have taken responsibility for correcting this issue in the Suricata GUI package. I have a PR ready for submission shortly after pfSense Plus 23.01 goes to RELEASE status that corrects this and a few other recently identified Suricata issues.

Will update this ticket when the correcting pull request is posted and ready for merging.

Here's the diff submitted previously FWIW:

diff --git a/security/pfSense-pkg-suricata/Makefile b/security/pfSense-pkg-suricata/Makefile
index 1660698811ce42954ffc80d17ad5b8fcacb3a9c4..379c8604c7c0b508c571457888ae0de27f97b327 100644
--- a/security/pfSense-pkg-suricata/Makefile
+++ b/security/pfSense-pkg-suricata/Makefile
@@ -2,7 +2,7 @@

 PORTNAME=    pfSense-pkg-suricata
 PORTVERSION=    6.0.8
-PORTREVISION=    8
+PORTREVISION=    9
 CATEGORIES=    security
 MASTER_SITES=    # empty
 DISTFILES=    # empty
diff --git a/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_ip_reputation.php b/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_ip_reputation.php
index 764241eb7b4834a824c80aac734d62fe557c323f..1d4b9582fb3e6ece992ea30ebe9f1c2db689a1b1 100644
--- a/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_ip_reputation.php
+++ b/security/pfSense-pkg-suricata/files/usr/local/www/suricata/suricata_ip_reputation.php
@@ -81,6 +81,10 @@ if ($_POST['mode'] == 'iplist_add' && isset($_POST['iplist'])) {
             }
         }
         if (!$input_errors) {
+            if (!is_array($a_nat['iplist_files'])){
+                $a_nat['iplist_files'] = array( "item" => array() );
+            }
+
             $a_nat['iplist_files']['item'][] = basename($_POST['iplist']);
             config_set_path("installedpackages/suricata/rule/{$id}", $a_nat);
             write_config("Suricata pkg: added new whitelist file for IP REPUTATION preprocessor.");
@@ -300,7 +304,7 @@ print($form);
                 </thead>
                 <tbody>
 <?php
-                if (is_array($pconfig['iplist_files']['item'])) :
+                if (is_array($pconfig['iplist_files']) && is_array($pconfig['iplist_files']['item'])) :
                     foreach($pconfig['iplist_files']['item'] as $k => $f) :
                         if (!file_exists("{$iprep_path}{$f}")) {
                             $filedate = gettext("Unknown -- file missing");

Thanks Marcos. I have already created the necessary fix and posted the commit to my personal FreeBSD-ports repo. I will create and post a Pull Request against the DEVEL branch of FreeBSD-ports in pfSense as soon as 23.01 exits RC status and goes RELEASE.

I have a few other GUI code changes included in the upcoming release of Suricata-6.0.10 for pfSense.

The pull request containing this fix has been posted for review and merge. The pull request can be viewed here: https://github.com/pfsense/FreeBSD-ports/pull/1227.

Once the request is merged, this issue can be marked "resolved".