pfSense

My configuration also has <gifs></gifs> and I can create a new GIF OK. I still can't find a way to reproduce this reliably. The problem here seems to be something different than an empty config element, though.

Somehow it's getting an array in the GIF interface field when it should be a string. It's not clear if that's coming from a call to pfSense_interface_create2("gif") on its own or if somehow the $_POST variable is getting an array value.

If someone can reproduce this, try going to Diagnostics > Command Prompt and running this in the PHP exec box:

var_dump( pfSense_interface_create2("gif") );

It should return a string like:

string(4) "gif0" 

If it's an array, then that's the reason it's failing.

If that is a string, then the problem is more likely coming from the POST values the client browser is submitting to interfaces_gif_edit.php which would be tricky to nail down remotely. First step would be to open the browser's debug panel to the network pane and then try to submit the form, and show the contents of the variables it submitted in the request.

This is going to have to wait unless someone can find a way to reproduce it reliably since I still am unable to replicate it.

I'm hitting this on a clean(ish) 23.05 armv7 install. Full log shows more errors:

Apr 25 23:18:34     php-fpm     1140     /interfaces_gif_edit.php: The command '/sbin/ifconfig Array tunnel 172.21.16.18 '172.21.16.59'' returned exit code '1', the output was 'ifconfig: interface Array does not exist'
Apr 25 23:18:34     php-fpm     1140     /interfaces_gif_edit.php: The command '/sbin/ifconfig Array '10.15.1.1' '10.15.1.2' netmask 255.255.255.252' returned exit code '1', the output was 'ifconfig: interface Array does not exist'
Apr 25 23:18:34     php-fpm     1140     /interfaces_gif_edit.php: PHP ERROR: Type: 1, File: /etc/inc/interfaces.inc, Line: 44, Message: Uncaught TypeError: pfSense_interface_flags(): Argument #1 ($ifname) must be of type string, array given in /etc/inc/interfaces.inc:44
Apr 25 23:18:34     php-fpm     1140     Stack trace:
Apr 25 23:18:34     php-fpm     1140     #0 /etc/inc/interfaces.inc(44): pfSense_interface_flags(Array, 1)
Apr 25 23:18:34     php-fpm     1140     #1 /etc/inc/interfaces.inc(1271): interfaces_bring_up(Array)
Apr 25 23:18:34     php-fpm     1140     #2 /usr/local/www/interfaces_gif_edit.php(124): interface_gif_configure(Array)
Apr 25 23:18:34     php-fpm     1140     #3 {main}
Apr 25 23:18:34     php-fpm     1140     thrown
Apr 25 23:18:34     php-fpm     1140     /interfaces_gif_edit.php: New alert found: PHP ERROR: Type: 1, File: /etc/inc/interfaces.inc, Line: 44, Message: Uncaught TypeError: pfSense_interface_flags(): Argument #1 ($ifname) must be of type string, array given in /etc/inc/interfaces.inc:44
Apr 25 23:18:34     php-fpm     1140     Stack trace:
Apr 25 23:18:34     php-fpm     1140     #0 /etc/inc/interfaces.inc(44): pfSense_interface_flags(Array, 1)
Apr 25 23:18:34     php-fpm     1140     #1 /etc/inc/interfaces.inc(1271): interfaces_bring_up(Array)
Apr 25 23:18:34     php-fpm     1140     #2 /usr/local/www/interfaces_gif_edit.php(124): interface_gif_configure(Array)
Apr 25 23:18:34     php-fpm     1140     #3 {main}
Apr 25 23:18:34     php-fpm     1140     thrown 

23.05-DEVELOPMENT (arm)
built on Mon Apr 24 06:04:52 UTC 2023
FreeBSD 14.0-CURRENT

The config file has no gif tags

Since MODULES_OVERRIDE was fixed in crossbuild at on 3 March 2023, all modules are no longer being built and included in the images. As it happens, for armv7 devices gif and tuntap are omitted from the kernconfs and have previously been available as KLDs. To rectify this, in crossbuild revision 1303b49 I have added the if_gif and if_tuntap modules to the overrides for armv7, the next snapshot build should use this updated crossbuild and include the modules in the resulting image.

This is closer but not enough, the module isn't automatically loaded when creating the GIF with pfSense_interface_create2, so we fail with the same error, which is happening in 23.01.

Applied in changeset 0449165411edfa1aaa37ca6f6dae5b9c56604c92.

Updating subject for release notes.

This is working well on current snapshots. Creating a GIF on a 3100 (ARMv7) loads the module and no longer generates a PHP error when creating a GIF interface.