Project

General

Profile

Actions
Copy link

Regression #14102

closed

Console menu incorrectly shows option ``99`` on some ARMv7/ARM64 installations

Added by Steve Wheeler almost 2 years ago. Updated over 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Luiz Souza
Category:
Console Menu
Target version:
23.05
Start date:
Due date:
% Done:

100%

Estimated time:
Release Notes:
Default
Affected Plus Version:
23.01
Affected Architecture:
SG-1100, SG-2100

Description

The console menu is intended to only show menu option 99 'Install to device' if pfSense is not running from eMMC or SATA.

However it's possible to incorrectly display it if the code creates an invalid device that then returns no results.

For example this 21.05.1 install:

[21.05.1-RELEASE][root@pfSense.home.arpa]/root: glabel status
                Name  Status  Components
         flash/uboot     N/A  flash/spi0s.uboot
      flash/ubootenv     N/A  flash/spi0s.ubootenv
diskid/DISK-B1D52868     N/A  mmcsd0
      msdosfs/EFISYS     N/A  diskid/DISK-B1D52868s1

The code here runs that:
https://gitlab.netgate.com/pfSense/factory/-/blob/plus-master/src/etc/rc.initial#L125

And creates an invalid device to test against:

+ /sbin/geom label status
+ /usr/bin/grep diskid/DISK-B1D52868
+ /usr/bin/awk '{ printf $3 }'
+ DEV=mmcsd0diskid/DISK-B1D52868s1

Hence it fails to find the eMMC device:

+ /sbin/geom disk list mmcsd0diskid/DISK-B1D52868s1
+ /usr/bin/grep MMCHC
+ MMCDEV=''

Actions
Copy link
 #1

Updated by Reid Linnemann almost 2 years ago

  • Assignee set to Reid Linnemann
Actions
Copy link
 #2

Updated by Reid Linnemann almost 2 years ago

I've simplified and improved the EMMC/SATA rootdev check for aarch64 devices. The modified script is more specific about matching the root dev label in the label list only in the first output field.

Actions
Copy link
 #3

Updated by Reid Linnemann almost 2 years ago

  • Status changed from New to Feedback

Fixed in 209cb8b1.

Actions
Copy link
 #4

Updated by Jim Pingle over 1 year ago

  • Status changed from Feedback to New

Hate to be the bearer of bad news but I still see option 99 offered on my 1100. It's running ZFS, not UFS, so there is no diskid, and mount -p / returns an error.

Actions
Copy link
 #5

Updated by Jim Pingle over 1 year ago

  • Status changed from New to Resolved
  • Assignee changed from Reid Linnemann to Luiz Souza
  • % Done changed from 0 to 100

After the latest Plus commit for this issue from Luiz (d470b17c454abb59f48846d361a260191655f1fe) it appears to be OK now. I no longer see option 99 on my 1100.

Actions
Copy link
 #6

Updated by Jim Pingle over 1 year ago

  • Subject changed from Console menu incorrectly shows option 99 to Console menu incorrectly shows option ``99`` on some ARMv7/ARM64 installations

Updating subject for release notes.

Actions
Copy link

Also available in: Atom PDF