Project

General

Profile

Actions

Regression #14102

closed

Console menu incorrectly shows option ``99`` on some ARMv7/ARM64 installations

Added by Steve Wheeler over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Console Menu
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Release Notes:
Default
Affected Plus Version:
23.01
Affected Architecture:
SG-1100, SG-2100

Description

The console menu is intended to only show menu option 99 'Install to device' if pfSense is not running from eMMC or SATA.

However it's possible to incorrectly display it if the code creates an invalid device that then returns no results.

For example this 21.05.1 install:

[21.05.1-RELEASE][root@pfSense.home.arpa]/root: glabel status
                Name  Status  Components
         flash/uboot     N/A  flash/spi0s.uboot
      flash/ubootenv     N/A  flash/spi0s.ubootenv
diskid/DISK-B1D52868     N/A  mmcsd0
      msdosfs/EFISYS     N/A  diskid/DISK-B1D52868s1

The code here runs that:
https://gitlab.netgate.com/pfSense/factory/-/blob/plus-master/src/etc/rc.initial#L125

And creates an invalid device to test against:

+ /sbin/geom label status
+ /usr/bin/grep diskid/DISK-B1D52868
+ /usr/bin/awk '{ printf $3 }'
+ DEV=mmcsd0diskid/DISK-B1D52868s1

Hence it fails to find the eMMC device:

+ /sbin/geom disk list mmcsd0diskid/DISK-B1D52868s1
+ /usr/bin/grep MMCHC
+ MMCDEV=''

Actions

Also available in: Atom PDF