Project

General

Profile

Actions
Copy link

Bug #15162

closed

Adding Wake-On-LAN entry from ARP table view can incorrectly include OEM text in MAC address field

Added by Sergei Shablovsky over 1 year ago. Updated 30 days ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Christian McDonald
Category:
Diagnostics
Target version:
2.8.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
25.03
Release Notes:
Default
Affected Version:
2.7.2
Affected Architecture:
All

Description

Hi, brilliant pfSense stuff!

Wrong string in “ MAC address ” txt entry field in “ Services / Wake-on-LAN / Edit ” when press on “ +* ” in “ *Actions ” column in “ Diagnostics / ARP Table ” page in WebGUI.

Files

Download all files
2CB1E7B8-5FCA-4892-B601-E2D0F0784416.jpeg (811 KB) 2CB1E7B8-5FCA-4892-B601-E2D0F0784416.jpeg Sergei Shablovsky, 01/13/2024 11:54 PM
06D0A425-99F6-4862-BCF8-4E7F684E8E9C.jpeg (2.63 MB) 06D0A425-99F6-4862-BCF8-4E7F684E8E9C.jpeg Sergei Shablovsky, 01/13/2024 11:54 PM
F3EDABF2-837F-4260-A02B-DB0CA1A79606.jpeg (459 KB) F3EDABF2-837F-4260-A02B-DB0CA1A79606.jpeg Sergei Shablovsky, 01/14/2024 12:02 AM
1BAF90CD-3E36-48CC-A55F-7D8EC8BF05CE.jpeg (811 KB) 1BAF90CD-3E36-48CC-A55F-7D8EC8BF05CE.jpeg Sergei Shablovsky, 01/14/2024 12:02 AM
Actions
Copy link
 #1

Updated by Sergei Shablovsky over 1 year ago

Sergei Shablovsky wrote:

Hi, brilliant pfSense stuff!

Wrong string in “ MAC address ” txt entry field in “ Services / Wake-on-LAN / Edit ” when press on “ +* ” in “ *Actions ” column in “ Diagnostics / ARP Table ” page in WebGUI.

As You may see, pfSense php logic doing something wrong: put in “MAC Address” entry field WHOLE text (certain MAC and DESCRIPTION, in this particular case “IBM” word) from “MAC Address” column.

Actions
Copy link
 #2

Updated by Christopher Cope over 1 year ago

  • Project changed from pfSense to pfSense Packages
  • Category changed from Web Interface to Nmap
  • Status changed from New to Confirmed
  • Priority changed from Normal to Very Low
  • Release Notes deleted (Default)

Sergei Shablovsky wrote in #note-1:

Sergei Shablovsky wrote:

Hi, brilliant pfSense stuff!

Wrong string in “ MAC address ” txt entry field in “ Services / Wake-on-LAN / Edit ” when press on “ +* ” in “ *Actions ” column in “ Diagnostics / ARP Table ” page in WebGUI.

As You may see, pfSense php logic doing something wrong: put in “MAC Address” entry field WHOLE text (certain MAC and DESCRIPTION, in this particular case “IBM” word) from “MAC Address” column.

This is an issue when installing nmap, as it adds the vendor information to the list and pfSense itself does not have that information normally, so the code doesn't expect anything other than a MAC address to be present.

I can confirm this with 

23.09.1-RELEASE (amd64)
built on Wed Dec 20 13:27:00 EST 2023
FreeBSD 14.0-CURRENT

nmap 1.4.4_7

Actions
Copy link
 #3

Updated by Jim Pingle over 1 year ago

  • Project changed from pfSense Packages to pfSense
  • Category changed from Nmap to Diagnostics
  • Release Notes set to Default

Though installing nmap activates the OUI info in the field, the code to handle that is not in the nmap package, but in the base system pages which utilize that data.

Actions
Copy link
 #4

Updated by Jordan G about 2 months ago

this still happens with the field for MAC address when creating a WOL entry from Diagnostics>ARP Table menu using pfSense 24.11 and nmap 1.4.4_8

removing nmap package seems to eliminate the additional data that gets populated in the field when creating a WOL entry

Actions
Copy link
 #5

Updated by Christian McDonald about 1 month ago

  • Status changed from Confirmed to In Progress
  • Assignee set to Christian McDonald
  • Plus Target Version set to 25.03
Actions
Copy link
 #6

Updated by Christian McDonald about 1 month ago

  • Subject changed from Wrong string in “MAC address” to MAC address field in Wake-on-LAN incorrectly includes manufacturer name from ARP table
  • Status changed from In Progress to Feedback
Actions
Copy link
 #7

Updated by Christian McDonald about 1 month ago

  • Target version set to 2.8.0
Actions
Copy link
 #8

Updated by Christian McDonald about 1 month ago

  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Danilo Zrenjanin about 1 month ago

  • Status changed from Feedback to Resolved

I tested the patch with the latest version 25.03, and it successfully resolves the reported issue.

I am marking this case resolved.

Actions
Copy link
 #10

Updated by Jim Pingle 30 days ago

  • Subject changed from MAC address field in Wake-on-LAN incorrectly includes manufacturer name from ARP table to Adding Wake-On-LAN entry from ARP table view can incorrectly include OEM text in MAC address field
Actions
Copy link

Also available in: Atom PDF