Regression #15337
closedpfSense-boot pkg fails install in UFS
0%
Description
Upgrading UFS installs to the current 24.03 snapshot fails when running the POST-INSTALL script inb the pfSense upgrade pkg:
Installed packages to be UPGRADED: pfSense-boot: 24.03.b.20240312.0600 -> 24.03.b.20240313.0600 [pfSense-core] Number of packages to be upgraded: 1 [1/1] Upgrading pfSense-boot from 24.03.b.20240312.0600 to 24.03.b.20240313.0600... [1/1] Extracting pfSense-boot-24.03.b.20240313.0600: .......... done /bin/sh: Syntax error: end of file unexpected (expecting "fi") pkg-static: POST-INSTALL script failed failed. Failed
This appears to be caused by the script truncating the UFS ID:
+ mount -p + awk '$2 ~ /^\/$/ { match($1, "[[:alpha:]/]+[[:digit:]]+"); print substr($1, RSTART, RLENGTH); }' + bootdevs=/dev/ufsid/6023315 + mount -p + awk '$2 ~/\/boot\/efi/' + [ -n '' ] + gpart show -p /dev/ufsid/6023315 + awk '$4 ~ /efi/ {print $3}' gpart: No such geom: /dev/ufsid/6023315.
Updated by Reid Linnemann 9 months ago
The regex to capture the root disk dev is insufficient, as the root partition can show up as a label as well as a partition device. Fix incoming.
Updated by Reid Linnemann 9 months ago
- Assignee changed from Reid Linnemann to Christian McDonald
Updated by Reid Linnemann 9 months ago
- Assignee deleted (
Christian McDonald)
Assigned to Christian as he has changes in the works to move all of this boot code management into pfSense-upgrade and dike out the boot template package altogether.
Updated by Jim Pingle 8 months ago
- Status changed from New to Feedback
- Assignee set to Christian McDonald
IIRC this is fixed now, or at least needs re-tested on current snaps.
Updated by Georgiy Tyutyunnik 8 months ago
tested on:
24.03-BETA (amd64)
built on Fri Mar 22 17:08:00 UTC 2024
FreeBSD 15.0-CURRENT
upgraded from 23.09.1 on UFS system, no issues detected, no pfSense-boot package upgrade in logs